Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for extra inspectables #206

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Allow support for extra inspectables #206

merged 3 commits into from
Apr 5, 2023

Conversation

simenandre
Copy link
Contributor

I was looking for a less boilerplate way to do what is described in #142. I feel like the extra inspectable array option is the way to go.

This will also make removing the custom middleware defined in nestjs-envalid possible.

Copy link
Owner

@af af left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I had forgotten all about this suggestion! The implementation looks good, could you just add some tests for the new behavior?

@simenandre
Copy link
Contributor Author

Thanks for this, I had forgotten all about this suggestion! The implementation looks good, could you just add some tests for the new behavior?

Added tests :)

@af af merged commit ce5c0e5 into af:main Apr 5, 2023
@af
Copy link
Owner

af commented Apr 5, 2023

Thanks!

@af
Copy link
Owner

af commented Apr 5, 2023

Published 8.0.0-beta.2 with this change

tuannm151 pushed a commit to BSSCommerce/shopify-envalid that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants