Add hints in strict mode #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Aug 23, 2017
|
|
||
| return envObj[name] | ||
| }, | ||
|
|
||
| set(name) { | ||
| set(target, name) { |
There was a problem hiding this comment.
this was a bug fixed in the first commit
SimenB
commented
Aug 23, 2017
| @@ -50,6 +50,20 @@ test('strict mode objects throw when attempting to mutate', () => { | |||
| const env = cleanEnv({ FOO: 'bar', BAZ: 'baz' }, { | |||
| FOO: str() | |||
| }, strictOption) | |||
| assert.throws(() => env.FOO = 'foooooo') | |||
| assert.throws(() => env.FOO = 'foooooo', '[envalid] Attempt to mutate environment value: FOO') | |||
There was a problem hiding this comment.
the bugfix (printed [object Object] before)
This was referenced Aug 23, 2017
|
This looks good! I just need to take it for a spin tonight before merging |
af
reviewed
Aug 23, 2017
lib/strictProxy.js
Outdated
| const meant = require('meant') | ||
|
|
||
|
|
||
| function didYouMean(scmd, commands) { |
There was a problem hiding this comment.
Minor point, but it'd be nice to use an arrow function here since most of the rest of the module uses them
|
@af rebased and made into arrow |
|
👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
meantis not widely used, but it was just merged intonpm(npm/npm#10382), so no worries using it IMO.