feat: replace js render to template #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afdesk
requested changes
Nov 27, 2024
go.mod
Outdated
| @@ -3,6 +3,18 @@ module github.com/afdesk/scan2html | |||
| go 1.19 | |||
go.mod
Outdated
| @@ -3,6 +3,18 @@ module github.com/afdesk/scan2html | |||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/afdesk/trivy-go-plugin v0.0.0-20230425141703-7d18a52213b0 | |||
| github.com/aquasecurity/trivy v0.38.3 | |||
There was a problem hiding this comment.
let's try to use the latest version
afdesk
requested changes
Dec 2, 2024
main.go
Outdated
| } | ||
|
|
||
| firstHTML, err := common.ReadPluginFile("first.html") | ||
| rootCmd, err := initFlags() |
There was a problem hiding this comment.
it seems initFlags isn't relevant, something like initRootCmd looks better, isn't it?
main.go
Outdated
| if err != nil { | ||
| log.Fatalf("failed to read html file: %v", err) | ||
| log.Fatalf("%+v", err) |
There was a problem hiding this comment.
fatal log without description doesn't look great
main.go
Outdated
| if err != nil { | ||
| log.Fatalf("failed to read html file: %v", err) | ||
| if err = rootCmd.Execute(); err != nil { | ||
| log.Fatalf("%+v", err) |
main.go
Outdated
| if err != nil { | ||
| log.Fatalf("Failed to display help message %v", err) | ||
| return err |
There was a problem hiding this comment.
maybe we should add some comment for this error too? It will be hard to look for a reason of unknown errors
nikpivkin
reviewed
Dec 2, 2024
nikpivkin
reviewed
Dec 2, 2024
nikpivkin
reviewed
Dec 2, 2024
nikpivkin
reviewed
Dec 2, 2024
nikpivkin
reviewed
Dec 2, 2024
DmitriyLewen
reviewed
Dec 2, 2024
| var ( | ||
| tempJsonFileName = "scan2html-report-temp.json" | ||
| version = "dev" | ||
| availableFlags = []string{"--html-result", "--load-result"} |
There was a problem hiding this comment.
We need to update README.MD (new flags, etc.)
There was a problem hiding this comment.
not all fields are centering.
e.g.:
There was a problem hiding this comment.
We need to think about secrets (perhaps in another PR).
afdesk
approved these changes
Dec 2, 2024
nikpivkin
approved these changes
Dec 2, 2024
DmitriyLewen
approved these changes
Dec 3, 2024
afdesk
added a commit
that referenced
this pull request
Dec 10, 2024
* init v3 * feat: replace js render to template (#57) * feat: replace js render to template * feat: add extra tables to template * ci: update release steps * test: add unit tests * ci: change test trigger branch * ci: change test trigger branch * fix: change path for testing * ci: add checkout * fix: add changes according PR reviews * test: update testdata * fix: add centering for fixed version * docs: update README.md * chore: add cmd short description * feat: add k8s scan report (#59) --------- Co-authored-by: olsova <olga.solopova@smartforce.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.