Fixed yOffset not being used to change y position of text

[Pluto8195]

addresses issue mentioned in #3762

simply included (+ data.yOffset) to mesh position of text
mesh.position.y = y * textScale + data.yOffset;

[ngokevin]

Hm, seems it's used at

aframe/src/components/text.js

Line 391 in ea2142b

function loadFont (src, yOffset) {

in a different way.

[Pluto8195]

I see, is there something wrong with that then? since changing the yOffset has no effect.

[Pluto8195]

@ngokevin can you explain what the yOffset value is suppose to effect?

[ngokevin]

Supposed to effect per-char offset but this solution might be able to replace it. I have to dig down to why the original offset logic was meant for.

[Pluto8195]

comment above schema
// yOffset to adjust generated fonts from tools that may have incorrect metrics.

but I find that being able to just manipulate the y makes formatting text generally much easier

[ngokevin]

Thanks for waiting.

Can you figure out what effect it has on these lines?

aframe/src/components/text.js

Line 401 in ea2142b

if (src.indexOf('/Roboto-msdf.json') >= 0) { yOffset = 30; }

... Does the yOffset stack? Is the Roboto font hack necessary any more?