Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use grip instead of targetRay space #5040

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented Apr 12, 2022

Description:
tracked-controls-webxr currently uses targetRaySpace to report controller pose with no option to change it. This PR adds the ability to specify gripSpace over targetRaySpace, while still keeping targetRaySpace as the default.

Changes proposed:

  • Adds a space property on both tracked-controls and tracked-controls-webxr to allow the user to specify gripSpace over targetRaySpace.

@dmarcos
Copy link
Member

dmarcos commented Apr 14, 2022

Thanks. What’s the use case?

@msub2
Copy link
Contributor Author

msub2 commented Apr 14, 2022

I was working on a physics hands demo where I was using just tracked-controls to get controller position and wanted some cubes to stand in for hands, but they'd automatically be centered at the target ray point instead of just being in the center of my hands. It would also be useful if you're simulating something like the player holding a sword or other tool, which would make less sense being based around the target ray point. I just think this is easier than having to manually get references to the refSpace and frame, calling getPose on that, and then setting it or having to apply some manual offset to the controller position.

@dmarcos
Copy link
Member

dmarcos commented Apr 21, 2022

Thanks for the PR and patience! Great stuff

@dmarcos dmarcos merged commit f5fbc2a into aframevr:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants