forked from tektoncd/plumbing
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The check labels job uses the PR pipeline resource to add a comment to the PR with instructions for developers in case of failure. That doesn't work though because in case of failure the sync-up side of the pipeline resource is not processed, so the commit is not written. Fix that by removing the pipeline resource and writing the instructions to the step log instead. The step log is linked in the github status details through the tekton dashboard. In future we might extend the github update service to include support for comments, but that would require support for results on failure: tektoncd/pipeline#3749 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
- Loading branch information
Showing
3 changed files
with
22 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters