Added SPARK Ada polygon merge code #82
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork with latest commits from AFRL
VVCAS-Sean
previously approved these changes
Mar 20, 2023
lhumphrey
suggested changes
Aug 25, 2023
There was a problem hiding this comment.
Ben,
Sorry it took so long to get around to reviewing this. One change I would request: src/ada/src/services should be reserved for services that are instantiated by the Service Manager. This is more of a library. I'm going to propose moving these files to src/ada/src/polygon.
We also have SPARK proof as part of CI. I can handle that later. To be clear, are you running SPARK proof on all of these files, or just a subset? And currently, SPARK discharges all but 73 undischarged VCs out of 1036 total (7%)? What version of SPARK are you using, and with what settings? Please let me know (by email or GitHub message or something), so I can handle the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains SPARK Ada polygon merge code
Currently has 73 undischarged VCs out of 1036 total (7%)