Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations missing 14th September 2024 build #1604

Closed
bittin opened this issue Sep 14, 2024 · 8 comments
Closed

Translations missing 14th September 2024 build #1604

bittin opened this issue Sep 14, 2024 · 8 comments

Comments

@bittin
Copy link

bittin commented Sep 14, 2024

Hey!

Had some time today to test Agama again (to install Leap 16 Alpha, and Tumbleweed) with this iso: https://download.opensuse.org/repositories/systemsmanagement:/Agama:/Devel/images/iso/agama-installer.x86_64-openSUSE.iso

and noticed a lot of tranlations was missing: https://imgur.com/a/qDMtXx9 even if the project is fully translated on Weblate: https://l10n.opensuse.org/projects/agama/-/sv/

(did send an email too)

other then that everything worked

@bittin bittin changed the title Translations missing Translations missing 14th September 2024 build Sep 14, 2024
@imobachgs
Copy link
Contributor

Hi!

The problem is that we are not considering TypeScript files in the scripts to build the .pot file (and we have moved quite some files to TypeScript recently).

Thanks for noticing!

@bittin
Copy link
Author

bittin commented Sep 16, 2024

Hi!

The problem is that we are not considering TypeScript files in the scripts to build the .pot file (and we have moved quite some files to TypeScript recently).

Thanks for noticing!

ah alright i see, well then you and me have something to do before the stable release

imobachgs added a commit that referenced this issue Sep 16, 2024
Fix for #1604. After converting many files to TypeScript, we discovered
that those files are not considered when building the `agama.pot` file.
@imobachgs
Copy link
Contributor

The translations are included again in #1611.

Thanks!

@bittin
Copy link
Author

bittin commented Sep 16, 2024

@imobachgs thx for fixing, will test some more when i feel less sick

@imobachgs
Copy link
Contributor

Thank you! Take care!

@bittin
Copy link
Author

bittin commented Sep 23, 2024

@imobachgs testing now with todays 23th Septembers iso: https://download.opensuse.org/repositories/systemsmanagement:/Agama:/Devel/images/iso/agama-installer.x86_64-openSUSE.iso , more Swedish now atleast, but its not fully complete yet but maybe there is some strings thats not on Weblate yet

@ancorgs
Copy link
Contributor

ancorgs commented Sep 23, 2024

It would be good to have some examples of missing translations, to check the reason(s)... which may be various.

@bittin
Copy link
Author

bittin commented Sep 23, 2024

It would be good to have some examples of missing translations, to check the reason(s)... which may be various.

Posted some in #1629 @ancorgs

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Sep 23, 2024
https://build.opensuse.org/request/show/1202590
by user IGonzalezSosa + anag+factory
- Version 10

- Change the license to GPL-2.0-or-later (gh#agama-project/agama#1621).

- Bring back zFCP management support (gh#agama-project/agama#1570).

- Consider TypeScript files for translation
  (gh#agama-project/agama#1604).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants