Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create slowroll.yaml #1674

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Create slowroll.yaml #1674

merged 3 commits into from
Oct 18, 2024

Conversation

WesfunOfficial
Copy link
Contributor

Slowroll.yaml is almost indentical to leap_160.yaml and tumbleweed.yaml but will eventually give users the option to install slowroll through agama. was unable to provide translations since i only speak english and i am unsure if there other arch's for slowroll besides x86_64

Slowroll is currently the only option not available to install via agama that (i believe) is not planning on using something different (like Aeon, Kalpa and Leap Micro)

Slowroll.yaml is almost indentical to leap_160.yaml and tumbleweed.yaml but to eventually give users the option to install slowroll through agama
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WesfunOfficial,

Thanks a lot for your contribution. I have a couple of questions, but in general you are heading in the right direction :-)

Please, add an entry in the changes file too (referencing this PR as gh#agama-project/agama#1674).

Regards,
Imo

products.d/slowroll.yaml Outdated Show resolved Hide resolved
description: 'A slightly slower rolling release of openSUSE designed to update
less often than Tumbleweed but more often than Leap without forcing users to
choose between "stable" and newer packages'
icon: Slowroll.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to add the icon to web/src/assets/products. In the future, the icon will be placed next to this definition, but we are not there yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imobachgs looks like I'm not allowed to add images only code, but it would be the file from https://en.opensuse.org/File:Slowroll_logo_by_pprmint_text.svg since it was uploaded by @bmwiedemann and appears to be official

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the color of the logo will change later to create some distinction from the other openSUSE distributions. We can update images when that happens.

products.d/slowroll.yaml Outdated Show resolved Hide resolved
products.d/slowroll.yaml Outdated Show resolved Hide resolved
products.d/slowroll.yaml Outdated Show resolved Hide resolved
products.d/slowroll.yaml Outdated Show resolved Hide resolved
WesfunOfficial and others added 2 commits October 17, 2024 15:54
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Made all changes requested in this file
@WesfunOfficial
Copy link
Contributor Author

@imobachgs changes have been committed if you would like to review :)

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, @WesfunOfficial! I tried the definition and it works.

JFYI, you can add all the changes in a single pull request (instead of opening #1682 and #1683). Anyway, I will review them and add the logo on a separate change.

@imobachgs imobachgs merged commit 8481af2 into agama-project:master Oct 18, 2024
imobachgs added a commit that referenced this pull request Oct 18, 2024
Added Slowroll to product list (gh##1674)

Change was requested by @imobachgs
imobachgs added a commit that referenced this pull request Oct 18, 2024
Added slowroll.yaml (pending PR #1674)
imobachgs added a commit that referenced this pull request Oct 18, 2024
#1674 added Slowroll to the list of products to install. Thanks
@WesfunOfficial. However, given that
only x86_64 repositories are available, we should limit it to this
architecture. Additionally I took
the opportunity to add the logo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants