Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): update dependencies 2024-12-12 #1830

Merged
merged 9 commits into from
Dec 12, 2024
Merged

chore(web): update dependencies 2024-12-12 #1830

merged 9 commits into from
Dec 12, 2024

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Dec 12, 2024 •
edited
Loading

Update web dependencies to their latest except React and PatternFly, since both has published major versions that should be updated in separated PRs with their corresponding migrations.

Following commands has been executed with success,

  • npm run eslint
  • npm run stylelint
  • npm run check-types
  • npm run server
  • npm run build
  • NODE_ENV=production npm run build

Note for reviewers

The motivation behind this dependencies update was to update from React 18.2 to 18.3 as a previous step towards React 19, as recommended in the React 19 migration guides

To help make the upgrade to React 19 easier, we’ve published a react@18.3 release that is identical to 18.2 but adds warnings for deprecated APIs and other changes that are needed for React 19.

We recommend upgrading to React 18.3 first to help identify any issues before upgrading to React 19.

While preparing the update the React dependency was updated as part of #1827, but since most of the work was already done I decided to go ahead with this.

Previous implicit update: #1827
Previous explicit update: #1612

@dgdavid
chore(web): update package dependencies
4ab231a 
By removing the package-lock.json file and running `npm install`. For
some reason, `npm update` got stuck.

Find below the diff of npm_outdate before and after this npm install.

--- npm_outdate_before_npm_install	2024-12-12 10:03:27.729222650 +0000
+++ npm_outdate_after_npm_install	2024-12-12 10:03:21.419117771 +0000
@@ -1,40 +1,15 @@
 Package	Current	Wanted	Latest	Location	Depended	by
-@babel/preset-react	7.25.9	7.26.3	7.26.3	node_modules/@babel/preset-react	web
-@eslint/js	9.15.0	9.16.0	9.16.0	node_modules/@eslint/js	web
-@icons-pack/react-simple-icons	10.1.0	10.2.0	10.2.0	node_modules/@icons-pack/react-simple-icons	web
 @material-symbols/svg-400	0.23.0	0.23.0	0.27.2	node_modules/@material-symbols/svg-400	web
 @patternfly/patternfly	5.4.2	5.4.2	6.0.0	node_modules/@patternfly/patternfly	web
-@patternfly/react-core	5.4.10	5.4.11	6.0.0	node_modules/@patternfly/react-core	web
-@patternfly/react-table	5.4.11	5.4.12	6.0.0	node_modules/@patternfly/react-table	web
-@tanstack/react-query	5.61.0	5.62.7	5.62.7	node_modules/@tanstack/react-query	web
-@testing-library/react	16.0.1	16.1.0	16.1.0	node_modules/@testing-library/react	web
-@types/react	18.3.12	18.3.16	19.0.1	node_modules/@types/react	web
-@types/react-dom	18.3.1	18.3.5	19.0.2	node_modules/@types/react-dom	web
-@typescript-eslint/eslint-plugin	8.15.0	8.18.0	8.18.0	node_modules/@typescript-eslint/eslint-plugin	web
-@typescript-eslint/parser	8.15.0	8.18.0	8.18.0	node_modules/@typescript-eslint/parser	web
-axios	1.7.7	1.7.9	1.7.9	node_modules/axios	web
-cspell	8.16.0	8.16.1	8.16.1	node_modules/cspell	web
-eslint	9.15.0	9.16.0	9.16.0	node_modules/eslint	web
-eslint-plugin-i18next	6.1.0	6.1.1	6.1.1	node_modules/eslint-plugin-i18next	web
-eslint-plugin-import-x	4.4.3	4.5.0	4.5.0	node_modules/eslint-plugin-import-x	web
-eslint-plugin-n	17.14.0	17.15.0	17.15.0	node_modules/eslint-plugin-n	web
-eslint-plugin-promise	7.1.0	7.2.1	7.2.1	node_modules/eslint-plugin-promise	web
-eslint-plugin-react-hooks	5.1.0-rc-fb9a90fa48-20240614	5.1.0	5.1.0	node_modules/eslint-plugin-react-hooks	web
-globals	15.12.0	15.13.0	15.13.0	node_modules/globals	web
-neostandard	0.11.8	0.11.9	0.12.0	node_modules/neostandard	web
-prettier	3.3.3	3.4.2	3.4.2	node_modules/prettier	web
-qunit	2.22.0	2.23.1	2.23.1	node_modules/qunit	web
+@patternfly/react-core	5.4.11	5.4.11	6.0.0	node_modules/@patternfly/react-core	web
+@patternfly/react-table	5.4.12	5.4.12	6.0.0	node_modules/@patternfly/react-table	web
+@types/react	18.3.16	18.3.16	19.0.1	node_modules/@types/react	web
+@types/react-dom	18.3.5	18.3.5	19.0.2	node_modules/@types/react-dom	web
+neostandard	0.11.9	0.11.9	0.12.0	node_modules/neostandard	web
 react	18.3.1	18.3.1	19.0.0	node_modules/react	web
 react-dom	18.3.1	18.3.1	19.0.0	node_modules/react-dom	web
 react-refresh	0.14.2	0.14.2	0.16.0	node_modules/react-refresh	web
 react-router-dom	6.28.0	6.28.0	7.0.2	node_modules/react-router-dom	web
-sass	1.81.0	1.82.0	1.82.0	node_modules/sass	web
-sass-loader	16.0.3	16.0.4	16.0.4	node_modules/sass-loader	web
-stylelint	16.10.0	16.11.0	16.11.0	node_modules/stylelint	web
 stylelint-config-standard-scss	13.1.0	13.1.0	14.0.0	node_modules/stylelint-config-standard-scss	web
 typedoc	0.26.11	0.26.11	0.27.4	node_modules/typedoc	web
-typedoc-plugin-merge-modules	6.0.3	6.1.0	6.1.0	node_modules/typedoc-plugin-merge-modules	web
-typedoc-plugin-missing-exports	3.0.2	3.1.0	3.1.0	node_modules/typedoc-plugin-missing-exports	web
 typescript	5.6.3	5.7.2	5.7.2	node_modules/typescript	web
-webpack	5.96.1	5.97.1	5.97.1	node_modules/webpack	web
-webpack-dev-server	5.1.0	5.2.0	5.2.0	node_modules/webpack-dev-server	web
@dgdavid
chore(web): update material-symbols to latest version
d96f14d
@dgdavid
chore(web): update neostandard to latest version
712c566
@dgdavid
chore(web): update stylelint-config-standard-scss
ecaecb7
@dgdavid
chore(web): update typedoc to its latest version
271092e
@dgdavid
chore(web): update TypeScript to latest version
68f2b7f
@dgdavid
fix(web): please ESLint by removing some imports dup
80a2e5d
@dgdavid
chore(web): silent some SCSS deprecation warnings
eb6f5b1 
All of them comming from Patternfly dependency, most probably becuase of
the change in latest sass-loader release for using the modern Sass JS
API, see webpack-contrib/sass-loader@10be1ba

In any case, it is just silencing two deprecations,

  - "import"

    > @import rules are deprecated and will be removed in Dart Sass 3.0.0.

    https://sass-lang.com/documentation/js-api/interfaces/deprecations/#import

    NOTE: already fixed in Patternfly v6, see patternfly/patternfly#6538

  - "global-builtin"

    > Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.

    https://sass-lang.com/documentation/js-api/interfaces/deprecations/#global_builtin

To know more, see https://sass-lang.com/documentation/breaking-changes/import/
@dgdavid
chore(web): please ESLint by keeping imports first
f338fbd
@dgdavid dgdavid changed the title chore(web): update dependencies 2024-09-16 chore(web): update dependencies 2024-12-12 Dec 12, 2024
@dgdavid dgdavid marked this pull request as ready for review December 12, 2024 15:12
@dgdavid dgdavid merged commit 2c2d188 into master Dec 12, 2024
6 checks passed
@dgdavid dgdavid deleted the update-deps-20241212 branch December 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgdavid @imobachgs