fix(storage): recover config if needed #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12431918378Details
💛 - Coveralls |
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
bsc#1234711
branch
from
8c49fd0 to
427873a
Compare
imobachgs
approved these changes
Dec 20, 2024
| @@ -159,6 +148,21 @@ def install_phase | |||
| end | |||
| # rubocop:enable Metrics/AbcSize | |||
|
|
|||
| def locale=(locale) | |||
There was a problem hiding this comment.
Thanks for moving this. I always think that it is misplaced, but I never fix it.
Merged
dgdavid
added a commit
that referenced
this pull request
Dec 23, 2024
## Problem There is collision between #1848 and #1840 where bootloader adds another interface with Get/SetConfig on Storage service. This result that generic access no longer works and needs access via specific interface. reported on slack https://suse.slack.com/archives/C02TLF25571/p1734924853266999 ## Solution Change code to avoid ambitious code. ## Testing - *Tested manually*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In autoinstallation, the storage config could be set before probing storage. If so, the probing action overwrites the config that was set from the autoinstall profile.
https://bugzilla.suse.com/show_bug.cgi?id=1234711
Solution
Hotfix for ensuring the storage config is preserved when doing probing for first time. A better solution should be provided for a correct management of the services and precedences.
Testing
Manually tested.