Button to add a drive to the storage proposal

[ancorgs]

Adds the following button to the new storage UI.

If there are no extra devices to add, the button is not displayed.

Missing

Unit tests are still missing

[ancorgs]

@dgdavid The tests are failing due to PatternFly type definitions. The property label only accepts a string for SelectGroup and for DropDownGroup. Although it accepts a ReactNode for MenuGroup.

In fact it works just fine, so the type restriction looks kind of arbitrary to me.

Is there a way to fix it without having to migrate the whole component to use a menu instead of a dropdown?

[joseivanlopez]

Please, define a MenuDeviceDescriptionProps type.

[dgdavid]

@dgdavid The tests are failing due to PatternFly type definitions. The property label only accepts a string for SelectGroup and for DropDownGroup. Although it accepts a ReactNode for MenuGroup.

In fact it works just fine, so the type restriction looks kind of arbitrary to me.

Is there a way to fix it without having to migrate the whole component to use a menu instead of a dropdown?

Looking at their code base and git history, look to me as an out-dated prop.
It's is true that internally SelectGroup is using MenuGroup. But hard to say whether it's label type is intentional or not.

What I can see is that MenuGroup#label was an string until two years ago, patternfly/patternfly-react#8219 and the component itself was added 5 years ago patternfly/patternfly-react@e867f09 While the SelectGroup#label types dates from 6 years ago.

So, maybe a bug report for PatternFly :)

Meanwhile, I'd migrate it to Menu if it does not hurt or, if you prefer, add a /** @ts-expect-error: reason text */ comment.

[dgdavid]

Would be nice if you add these missing tests 😈