Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains restructuring of the Filters class.
What was done:
BuiltinFilters
classBuiltinFilters
classFilters#chain(...)
method into a separateFilterChain
classWhy:
It makes it easier for new users to understand the purpose of each of the new classes.
BuiltinFilters
class contains built-in filters that can be used out-of-the-box.Fitlers
class is now a class which can be used to build new custom filters.FilterChain
class is used for building filter-chains, nothing else.By separating these 3 constructs into separate classes, new users will have an easier time picking up on how filtering works in ExpectIt.
Downside:
Doing this breaks compatibility with existing code that was importing
Filters
class to use the built-in filters. Users will have to change imports to the newBuiltinFilters
class.Same with the new
FilterChain
class.