Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added proof of iso from section and retraction #398

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Added proof of iso from section and retraction #398

merged 3 commits into from
Oct 11, 2023

Conversation

jmarkakis
Copy link
Contributor

No description provided.

JacquesCarette
JacquesCarette requested changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor changes (throughout) would be appreciated to make this more in line with the rest of the library - but these are very welcome additions, thank you.

src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
JacquesCarette
JacquesCarette requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking much nicer now, thanks. I give one example of a where in the comments.

src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
src/Categories/Morphism/Properties.agda Outdated Show resolved Hide resolved
@jmarkakis
Copy link
Contributor Author

I believe that the last pushed resolves both the empty lines, and adds the where clauses where needed

@JacquesCarette JacquesCarette merged commit 4e0173c into agda:master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmarkakis @JacquesCarette