Fix config copy tool #336
Open
Fix config copy tool #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrddunbr
added
bug
|
Oh, I see what happened here :) That boolean used to be an or before Jared accidentally changed it to an and in a recent refactor. Looks like it'll only work now if you're both sneaking and holding the Wrench key (default C, IIRC)? Instead of removing the Wrench option (which is used in some other places), can we just change the operator back to an or? @jrddunbr I'll defer to you as to how much you want to keep "Wrench key" functionality :P |
|
I'd say that whatever I broke in the refactor was broke. The intent is that if your hand is empty, you can use the wrench tool. That context is lost if you're holding the CCT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, a fix for the config copy tool.