Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview sometimes doesn't render #72

Closed
NoxHarmonium opened this issue Sep 18, 2019 · 2 comments · Fixed by #73
Closed

Preview sometimes doesn't render #72

NoxHarmonium opened this issue Sep 18, 2019 · 2 comments · Fixed by #73
Labels
bug Something isn't working released

Comments

@NoxHarmonium
Copy link
Contributor

I've noticed that sometimes when toggling the extension, the extension pane comes up but the components don't render. Toggling the extension on and off again usually fixes the issue. I think it is more prevalent in Firefox.
@NoxHarmonium NoxHarmonium added the bug Something isn't working label Sep 18, 2019
@NoxHarmonium
Copy link
Contributor Author

Seems like some more strange issues with scheduling and interaction between Reagent and React. I will try moving the render method outside of the upstream library and see if that helps (agiledigital/mule-preview#23)

NoxHarmonium pushed a commit that referenced this issue Sep 21, 2019
fix: fix rendering issue in Firefox
8b3ff60 
This fix moves the responsibility of the rendering into the extension, rather than the mule-preview
plugin. An issue was uncovered  where the latest version of React (16.9.0) does not work in Firefox
browser extensions due to a change to the scheduler (facebook/react#16606)
so React was downgraded. After those fixes were implemented, the issue with rendering only working
correctly the second time the extension was triggered was fixed.

fix #72
NoxHarmonium pushed a commit that referenced this issue Sep 21, 2019
fix: fix rendering issue in Firefox
5c2a51e 
This fix moves the responsibility of the rendering into the extension, rather than the mule-preview
plugin. An issue was uncovered  where the latest version of React (16.9.0) does not work in Firefox
browser extensions due to a change to the scheduler (facebook/react#16606)
so React was downgraded. After those fixes were implemented, the issue with rendering only working
correctly the second time the extension was triggered was fixed.

fix #72
NoxHarmonium pushed a commit that referenced this issue Sep 21, 2019
fix: fix rendering issue in Firefox
c7fe872 
This fix moves the responsibility of the rendering into the extension, rather than the mule-preview
plugin. An issue was uncovered  where the latest version of React (16.9.0) does not work in Firefox
browser extensions due to a change to the scheduler (facebook/react#16606)
so React was downgraded. After those fixes were implemented, the issue with rendering only working
correctly the second time the extension was triggered was fixed.

fix #72
@NoxHarmonium NoxHarmonium mentioned this issue Sep 21, 2019
Merged
NoxHarmonium pushed a commit that referenced this issue Sep 21, 2019
@semantic-release-bot
chore(release): 1.0.18 [skip ci]
4b0007e 
## [1.0.18](v1.0.17...v1.0.18) (2019-09-21)

### Bug Fixes

* fix rendering issue in Firefox ([c7fe872](c7fe872)), closes [#72](#72)
@NoxHarmonium
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.0.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix rendering issue in Firefox agiledigital/mule-preview-browser-extension
1 participant
@NoxHarmonium