Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows users get UAC prompt, fixes #40 #86

Closed
wants to merge 1 commit into from
Closed

Windows users get UAC prompt, fixes #40 #86

wants to merge 1 commit into from

Conversation

QWp6t
Copy link

@QWp6t QWp6t commented Nov 17, 2015

There are three modifications in this PR. The only change of significance is obviously the first one. I just want to explain what it is you're looking at when you review the PR.

  • Windows users will now get a UAC prompt to edit their hosts file
  • README.md has a note for suppressing UAC prompts using cacls
  • Cleaned up README.md as well so it uses consistent styling throughout.

I was able to add the UAC prompt without any third-party dependencies, something that was desirable in #40.

So far in my testing, this solution has worked without errors.

@cgsmith cgsmith self-assigned this Dec 8, 2015
@cgsmith cgsmith added this to the 1.0.2 milestone Dec 8, 2015
@QWp6t QWp6t closed this Jul 20, 2016
cgsmith added a commit that referenced this pull request Aug 11, 2016
Widnows users get UAC Prompt and fixes #40 thanks to @QWp6t (#86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants