forked from argoproj/argo-workflows
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(deps): fix git push
during yarn.lock
deduplication for Dependabot PRs [actions testing PR]
#3
Closed
Commits on Apr 4, 2024
-
ci(deps): fix
git push
duringyarn.lock
deduplication- `actions/checkout` runs `git checkout` on a specific commit SHA, meaning there is no "branch" by default, it's on a detached `HEAD` - so without a branch specified, it would error out - so specify a branch using [GH Actions env vars](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) - note that `$GITHUB_HEAD_REF` should exist for PRs, and dependabot makes PRs (vs. direct `push`es) - use `origin` as the remote name which is the default and also was mentioned in the error message - also short-circuit the logic if there are no changes to `yarn.lock` (i.e. no deduplication neceessary) - this should also be less buggy as the later code will only execute when strictly necessary now (basically, when not needed, returns to the previous behavior before this step existed) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9629f66 - Browse repository at this point
Copy the full SHA 9629f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e2601f - Browse repository at this point
Copy the full SHA 9e2601fView commit details
Commits on Apr 5, 2024
-
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 67a8485 - Browse repository at this point
Copy the full SHA 67a8485View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c5c6c5 - Browse repository at this point
Copy the full SHA 7c5c6c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1a6699 - Browse repository at this point
Copy the full SHA d1a6699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f5047d - Browse repository at this point
Copy the full SHA 7f5047dView commit details -
This reverts commit 7f5047d. Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4177c4a - Browse repository at this point
Copy the full SHA 4177c4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c45cfa1 - Browse repository at this point
Copy the full SHA c45cfa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd080b - Browse repository at this point
Copy the full SHA 0bd080bView commit details -
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3af611c - Browse repository at this point
Copy the full SHA 3af611cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.