Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force a specific jQuery version. #31

Merged
merged 1 commit into from
Jan 29, 2014
Merged

Do not force a specific jQuery version. #31

merged 1 commit into from
Jan 29, 2014

Conversation

tuxcanfly
Copy link
Member

Let users include their own version of jQuery as they see fit. Using the jquery-latest URL is not recommended, either (no pinned version, can't send good cache headers).

Additionally, there's no need to include jQuery in the Admin mixin as jQuery's already included there.

@suhailvs
Copy link

so what are the stuffs to be changed... i mean parsley requires jquery. User may already defined the jquery in the template. so it is better to remove the jquery from it.

So that user can set jquery verision he likes.

@tuxcanfly
Copy link
Member

The problem is parsley.js doesn't work with the jquery included in django admin ($ is undefined, django namespaces it to django.jQuery) and the version is also outdated.

Agreed about jquery-latest. We could bundle a fixed version instead and update it periodically.

Or we could add an option to include jquery or not as a kwarg to the decorator and mixin. Just want the mixin to be plug and play like it currently is.

tuxcanfly added a commit that referenced this pull request Jan 29, 2014
Do not force a specific jQuery version.
@tuxcanfly tuxcanfly merged commit 617041d into master Jan 29, 2014
@tuxcanfly
Copy link
Member

Thanks @julianwachholz we'll not worry about form media and allow users to include it by their own.

@tuxcanfly tuxcanfly deleted the form-media branch January 29, 2014 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants