Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #66

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Bump versions #66

merged 3 commits into from
Aug 9, 2024

Conversation

agnivade
Copy link
Owner

@agnivade agnivade commented Aug 9, 2024

  • used debug flag
  • install latest chrome in CI

Tentatively Fix #59

- used debug flag
- install latest chrome in CI
@agnivade agnivade merged commit 0667919 into master Aug 9, 2024
12 checks passed
@agnivade agnivade deleted the bumpver branch August 9, 2024 05:04
@agnivade
Copy link
Owner Author

agnivade commented Aug 9, 2024

@hajimehoshi - It's possible that this PR has potentially solved the websocket URL timeout issue. What I did was:

  • updated the chromedp library to latest.
  • used the latest chrome version in CI. I noticed that in your CI, you are not installing the latest chrome separately. Would recommend doing that
 - name: Install chrome
      uses: browser-actions/setup-chrome@latest

I ran the PR CI 3 times, and then after merging, it passed again in master. So there's some confidence that likely it has fixed. Do give it a try and let me know.

@hajimehoshi
Copy link
Contributor

Sure, I'll try the latest wasmbrowsertest for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test TestRun/panic_fails in Windows
2 participants