-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added modman config #11
Conversation
src/app/design/frontend/base/default/layout/* app/design/frontend/base/default/layout/ | ||
src/app/etc/modules/* app/etc/modules/ | ||
src/app/locale/en_US/* src/app/locale/en_US/ | ||
src/app/locale/zh_TW/* src/app/locale/zh_TW/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the rest of the locales also required? I'm familiar with modman.
cc @mreeves1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops. My bad. Added all missing locales in my next commit.
Yes, (belatedly) I think that makes sense. Sorry I don't usually use locales and was in a rush to use this extension with a magento install using modman. Also how did you see my contribution? I thought I had issued a pull request to zendesk with this and one other thing but I don't see it now. |
@mystix Thanks - looks like modman has a shortcut for if we need anymore translations in the future - https://github.com/colinmollenhour/modman/wiki/Productivity-Hints @mreeves1 I've closed your old pull request #10 as new PRs replaced it. |
👍 |
added modman config file
for easy installation using @colinmollenhour's excellent modman script