Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getModuleDir call #12

Merged
merged 1 commit into from
Jul 29, 2013
Merged

Fix getModuleDir call #12

merged 1 commit into from
Jul 29, 2013

Conversation

rjocoleman
Copy link
Contributor

Warning: Missing argument 2 for Mage::getModuleDir(), called in /app/code/community/Zendesk/Zendesk/controllers/Adminhtml/ZendeskController.php on line 18 and defined in /app/Mage.php on line 338

This is found when accessing anything that calls the JWT.php helper.

I have found this in CE 1.7.0.2. The issue was introduced in 74757fe.

Uses DS as directory separator for compatibility reasons.

Reference: http://docs.magentocommerce.com/Mage_Core/Mage_Core_Model_Config.html#getModuleDir

Replaces #10 with a single change PR.

@jwswj
Copy link
Contributor

jwswj commented Jul 29, 2013

👍 Thanks @rjocoleman

jwswj pushed a commit that referenced this pull request Jul 29, 2013
@jwswj jwswj merged commit 0260989 into agnostack:master Jul 29, 2013
@jwswj
Copy link
Contributor

jwswj commented Jul 29, 2013

cc @zendesk/adam-panzer @maximeprades

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants