Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept any 2xx status code in otlplogshttp client #26

Merged

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Oct 25, 2023

This ensures that any 2xx server side response is seen as successful.

For example: Grafana Cloud's OTLP endpoints will reply with 204 to make it clear there is no body in the response. This is seen as failed without this change.

@simonswine simonswine marked this pull request as ready for review October 25, 2023 09:06
@simonswine simonswine force-pushed the 20231025_accept-any-2xx-status-code branch from 841a59a to 1bb1976 Compare October 25, 2023 09:06
@chameleon82 chameleon82 changed the title Accept any 2xx status code fix: accept any 2xx status code in otlplogshttp client Oct 25, 2023
This ensure that any 2xx server side response is seen as successful.

For example: Grafana Cloud's OTLP gateway will reply with `204` to make
it clear there is no body in the response. This is seen as failed
without this change.
@simonswine simonswine force-pushed the 20231025_accept-any-2xx-status-code branch from 1bb1976 to 1288e8d Compare October 25, 2023 13:29
@chameleon82 chameleon82 self-requested a review October 25, 2023 13:35
@chameleon82
Copy link
Collaborator

Thank you @simonswine for contribution!

@chameleon82 chameleon82 merged commit 6404fae into agoda-com:master Oct 25, 2023
1 check passed
@chameleon82 chameleon82 mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants