Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build-proposals Makefile target #1

Closed
wants to merge 6 commits into from
Closed

Conversation

dckc
Copy link

@dckc dckc commented Sep 22, 2023

  • separate building proposals from putting them on chain
  • collect bundles, permits, etc. in dist/ and dist/bundles/ dirs
  • helpful diagnostic if $KREAD_COMMITTEE_ADDRESSES is not set

cc @turadg

rather than: SyntaxError#1: Unexpected token u in JSON at position 0
 - separate building proposals from putting them on chain
 - collect bundles, permits, etc. in dist/ and dist/bundles/ dirs
@dckc dckc requested a review from iomekam September 22, 2023 18:14
Copy link
Collaborator

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turadg
Copy link

turadg commented Sep 23, 2023

This is all in develop now.

@turadg turadg closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants