Merge v0.34.23-alpha.agoric.4 #5
Conversation
Mitigation for asa-2023-002
|
Moving to draft as we're landing this change on the tendermint fork first, and will merge that change here instead. |
mhofman
changed the title
BlockParams.MaxBytes
mhofman
force-pushed
the
mhofman/8483-max-block-size
branch
from
404eb7b
to
1b4ae52
Compare
| ## [v0.34.23-alpha.agoric.4] | ||
|
|
||
| * Lower default `BlockParams.MaxBytes` to 5MB to mitigate asa-2023-002 | ||
|
|
There was a problem hiding this comment.
Drop this since we won't be adding this tag to this repository, but move this description up to line 41.
There was a problem hiding this comment.
This is a merge of the tendermint commit. We should only resolve merge conflicts, not introduce content changes. Is there a reason to exclude this version from the log when other changes that agoric made are included, associated to the respective version where the change was originally made?
Regarding ordering, they're purposely not in "version order" to make clear that v0.34.27-alpha.agoric.2 doesn't include this change.
There was a problem hiding this comment.
This is a bit of a gray area, so proceed if you feel strongly, but I'd rather see this as its own commit since we're no longer lifting tendermint changes into cometbft.
There was a problem hiding this comment.
In general I prefer to merge instead of cherry-picking or porting, as it's clearer what is and isn't integrated.
Description
Merge
v0.34.23-alpha.agoric.4which pulls in agoric-labs/tendermint#36, a mitigation for asa-2023-002.Also fixes the Agoric specific changelog.
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments