fix: halt-height behavior is not deterministic #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
approved these changes
Sep 18, 2023
CHANGELOG.md
Outdated
| @@ -37,6 +37,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| * (baseapp) [#305](https://github.com/agoric-labs/cosmos-sdk/pull/305) Make sure we don't execute blocks beyond the halt height. | |||
There was a problem hiding this comment.
Move this to CHANGELOG-Agoric.md - creating it if #306 doesn't land first.
(Moving our changes to a separate file makes it easier to merge changes from cosmos.)
Also, note that it's a backport of cosmos#16639. This will also make future merges easier.
There was a problem hiding this comment.
Done, but I'll wait until #306 merges first.
Port of cosmos#16639 Co-authored-by: yihuang <huang@crypto.com>
mhofman
force-pushed
the
mhofman/8326-check-halt-begin
branch
from
a7b31b8
to
762e033
Compare
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 5, 2023
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
JimLarson
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit 7b8423a. This commit caused test failures in agoric-sdk. Reverting to land other changes in agoric-sdk. We'll restore the change and try to debug the failure against a smaller diff in the future.
20 tasks
michaelfig
pushed a commit
that referenced
this pull request
Nov 9, 2023
Port of cosmos#16639 Co-authored-by: yihuang <huang@crypto.com>
20 tasks
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 9, 2023
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 10, 2023
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 10, 2023
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 13, 2023
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
JimLarson
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Nov 13, 2023
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
michaelfig
pushed a commit
that referenced
this pull request
Dec 3, 2023
Port of cosmos#16639 Co-authored-by: yihuang <huang@crypto.com>
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 6, 2023
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Dec 6, 2023
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
michaelfig
pushed a commit
that referenced
this pull request
Jul 5, 2024
Port of cosmos#16639 Co-authored-by: yihuang <huang@crypto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Agoric/agoric-sdk#8326
Port (cherry-pick with modifications) of cosmos#16639
Adapt by using
BeginBlockandpanic, similar to the adaptation in crypto-org-chain/chain-main#998Adapted the Unit test as well
Once we reach the version of cosmos-sdk (v0.50) with the
FinalizeBlocksemantics (CometBFT v0.38), we can adopt the upstream change more directly.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change