Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence some lint warnings #404

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore: silence some lint warnings #404

merged 1 commit into from
Mar 5, 2024

Conversation

JimLarson
Copy link

Description

Refs: Agoric/agoric-sdk#9034

Clean up some lint warnings in our added or modified code.

Not trying to fix errors that are not fixed in the surrounding code, e.g. Wrapf().

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JimLarson JimLarson added the agoric-cosmos Agoric tags for cosmos label Mar 5, 2024
@JimLarson JimLarson self-assigned this Mar 5, 2024
Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Do you maybe want to adopt the deprecation-error avoidance that was done in Agoric/agoric-sdk#8866 ?

@JimLarson
Copy link
Author

The deprecation warnings go away in future releases, so I'd rather not take on the extra diffs.

@JimLarson JimLarson merged commit a0154d6 into Agoric Mar 5, 2024
28 of 29 checks passed
@JimLarson JimLarson deleted the jimlarson-lint branch March 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants