Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup to integrate Keplr with Synpress #1

Merged

Conversation

rabi-siddique
Copy link
Collaborator

@rabi-siddique rabi-siddique commented Feb 28, 2024

The PR segregates Keplr and Metamask implementations, to allow making it easier to modify the code to ensure each module focuses on its specific tasks.

What I did:

  • Created an object containing methods that involve interaction with Keplr Extension inside playwright-keplr.js. The Meta-mask-specific implementations are moved to playwright-metamask.js.
  • Separate operations relevant to Keplr in keplr.js in the commands folder. In the same folder, Meta-mask-specific stuff is present in metamask.js.
  • Separate plugin configs for Meta-mask and Keplr in plugins folder.
  • Test cases for Keplr are placed in keplr.spec.js file. While Meta-mask-specific test cases are in metamask.spec.js.
  • The differentiation between using Keplr-relevant configs and test cases is being identified through an environment variable EXTENSION that is passed through a package.json script.
  • Added an implementation to download the Keplr Extension based on the provided version through an environment variable.

plugins/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@frazarshad frazarshad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can start with this as the base and can make any refinements needed later

@rabi-siddique rabi-siddique merged commit 3cc4781 into agoric-labs:dev Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants