Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove whitespaces around extension id #54

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: remove whitespaces around extension id #54

merged 1 commit into from
Nov 15, 2024

Conversation

rabi-siddique
Copy link
Collaborator

@rabi-siddique rabi-siddique commented Nov 15, 2024 •
edited
Loading

The PR does the following:

Testing

  • Clone this repo. Install all the dependencies. Checkout into this branch.
  • Then use this repo as an npm package in any dapp. You can do that by: 
    yarn add -D /Users/rabisiddique/Desktop/Work/synpress
    /Users/rabisiddique/Desktop/Work/synpress is location where synpress is located on my computer. Adjust the path according to where you clone synpress.
  • Follow the README of the dapp to run e2e tests. If the tests are able to setup a Keplr Wallet, that means, everything is working as expected.

@rabi-siddique rabi-siddique force-pushed the rs-fix-extension-id-issue branch from a3a4c17 to 94b1b8d Compare November 15, 2024 10:24
@rabi-siddique rabi-siddique changed the base branch from master to dev November 15, 2024 10:25
@rabi-siddique rabi-siddique force-pushed the rs-fix-extension-id-issue branch from 94b1b8d to 139215c Compare November 15, 2024 10:27
@rabi-siddique rabi-siddique changed the base branch from dev to master November 15, 2024 10:29
@rabi-siddique rabi-siddique linked an issue Nov 15, 2024 that may be closed by this pull request
Tests failing with chrome #53
Closed
@rabi-siddique rabi-siddique self-assigned this Nov 15, 2024
@rabi-siddique rabi-siddique changed the base branch from master to dev November 15, 2024 10:50
@rabi-siddique rabi-siddique force-pushed the rs-fix-extension-id-issue branch 2 times, most recently from e923322 to 6ed62fd Compare November 15, 2024 10:54
@rabi-siddique rabi-siddique force-pushed the rs-fix-extension-id-issue branch from 6ed62fd to b9c18e3 Compare November 15, 2024 10:56
@rabi-siddique rabi-siddique merged commit 1488846 into dev Nov 15, 2024
2 checks passed
@rabi-siddique rabi-siddique deleted the rs-fix-extension-id-issue branch November 15, 2024 11:00
rabi-siddique added a commit that referenced this pull request Nov 15, 2024
@rabi-siddique
fix: remove whitespaces around extension id (#54)
221d49c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frazarshad frazarshad frazarshad approved these changes

Assignees

@rabi-siddique rabi-siddique

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests failing with chrome
2 participants
@rabi-siddique @frazarshad