-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated dev tools, fix: non-breaking requests version #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great. Let's get the ci stuff aligned with our best practices and then i'm excited to test the setuptools deploy. Will we need to get pypi ready for the new package name prior to a release being pushed?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 90.00% 90.39% +0.39%
==========================================
Files 4 3 -1
Lines 230 229 -1
Branches 25 23 -2
==========================================
Hits 207 207
+ Misses 20 19 -1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
I did some work on the actions stuff for this. @steveoh Would you mind taking another look? I'm also not clear on how the publish will go with the new package name. Do I need to do anything on the pypi end before it's published? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great.
The main purpose is to pin the
requests
version to an older package that is compatible witharcgis
.I took the opportunity to update the dev tools/actions to match the latest patterns.