Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated dev tools, fix: non-breaking requests version #37

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Conversation

jacobdadams
Copy link
Member

The main purpose is to pin the requests version to an older package that is compatible with arcgis.

I took the opportunity to update the dev tools/actions to match the latest patterns.

@jacobdadams jacobdadams requested a review from steveoh January 15, 2025 18:51
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great. Let's get the ci stuff aligned with our best practices and then i'm excited to test the setuptools deploy. Will we need to get pypi ready for the new package name prior to a release being pushed?

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/supervisor/example.py Outdated Show resolved Hide resolved
src/supervisor/example.py Outdated Show resolved Hide resolved
.github/workflows/push.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.39%. Comparing base (c023f6e) to head (97bd5df).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/supervisor/models.py 40.00% 3 Missing ⚠️
src/supervisor/message_handlers.py 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   90.00%   90.39%   +0.39%     
==========================================
  Files           4        3       -1     
  Lines         230      229       -1     
  Branches       25       23       -2     
==========================================
  Hits          207      207              
+ Misses         20       19       -1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdavis
Copy link
Member

stdavis commented Jan 23, 2025

I did some work on the actions stuff for this. @steveoh Would you mind taking another look? I'm also not clear on how the publish will go with the new package name. Do I need to do anything on the pypi end before it's published?

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great.

.github/workflows/push.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@steveoh steveoh merged commit 4492e39 into main Jan 23, 2025
6 checks passed
@steveoh steveoh deleted the dev branch January 23, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants