Login to earthexplorer is only performed once per batch of files

[janosrusiczki]

Moved the earthexplorerLogin() call up the stack so it is only performed once per the batch of files to be downloaded. Additionally made sure the function call is only performed if there are SRTM sources present (wrote a small function to check for that).

Fixes #23

[agrenott]

Thanks for your contribution.
I'm currently off, I'll review it when I'm back.

[janosrusiczki]

@agrenott enjoy your holidays, I can work with my branch until then.

As an additional information I tested with this command and works fine:

pyhgtmap \
  -o contour \
  --step=10 \
  -0 \
  --pbf \
  --hgtdir=/mnt/data/hgt \
  -a $LEFT:$BOTTOM:$RIGHT:$TOP \
  --earthexplorer-user=$EE_USER \
  --earthexplorer-password=$EE_PASSWORD

But I think it should be tested with other sources also.

[agrenott]

Looks good considering the overall file's state (NASASRTMUtil would need an overall re-engineering, probably using some API instead of web scraping).
Tested your change rebased on my latest, it works with SRTM1, SRTM3 and view1 sources.

Can you please rebase your PR on the latest master, as this will fix the typing issue?

[janosrusiczki]

Coming up!

…

On Mon, Aug 14, 2023 at 2:46 AM Aurélien Grenotton ***@***.***> wrote: Looks good considering the overall file's state (NASASRTMUtil would need an overall re-engineering, probably using some API instead of web scraping). Tested your change rebased on my latest, it works with SRTM1, SRTM3 and view1 sources. Can you please rebase your PR on the latest master, as this will fix the typing issue? — Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABOIHDTWJXGG2R3ZDZHIXTXVFROZANCNFSM6AAAAAA3G6NT3A> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[janosrusiczki]

Didn't rebase, used the sync fork button on the website which did a merge. Checks are now passing.

[janosrusiczki]

Looks good considering the overall file's state (NASASRTMUtil would need an overall re-engineering, probably using some API instead of web scraping).

Let's cross that bridge when we get to it. 😄

I'm working on a set of Docker images to set up an Open Topo Map tile renderer and finding your package was a blessing anyway, the original one being abandoned...