Add metrics of client #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/libpgagroal/worker.c
Outdated
| @@ -159,6 +163,9 @@ pgagroal_worker(int client_fd, char* address, char** argv) | |||
| /* The slot may have been updated */ | |||
| slot = client_io.slot; | |||
| } | |||
|
|
|||
| pgagroal_prometheus_client_active_sub(); | |||
| pgagroal_prometheus_client_wait_add(); | |||
There was a problem hiding this comment.
I understand where you are coming from.
However, I don't think we need to put client shutdown into the client_wait category, since we are basically exiting shortly.
Hence we can remove client_wait_add() from here
src/libpgagroal/worker.c
Outdated
| @@ -242,6 +249,8 @@ pgagroal_worker(int client_fd, char* address, char** argv) | |||
| pgagroal_log_debug("client disconnect: %d", client_fd); | |||
| pgagroal_disconnect(client_fd); | |||
|
|
|||
| pgagroal_prometheus_client_wait_sub(); | |||
There was a problem hiding this comment.
Therefore we can move this to the else
|
Review my comments, squash, amend commit message with issue number, and force push |
Add the following metrics: * pgagroal_client_active * pgagroal_client_wait Close agroal#156
Done |
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following metrics:
Close #156