Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setSystemFactoryDefault request #138

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

bl0ggy
Copy link
Contributor

@bl0ggy bl0ggy commented Feb 20, 2020

Nothing to say about this. Just add a new ONVIF request.

@coveralls
Copy link

coveralls commented Feb 20, 2020

Coverage Status

Coverage decreased (-4.9%) to 82.395% when pulling bb73538 on bl0ggy:add_setSystemFactoryDefault into 2a7f9fe on agsh:master.

@bl0ggy
Copy link
Contributor Author

bl0ggy commented Feb 20, 2020

I added a test, but it covers less than before ?
I think coveralls has a bug haha, probably because I made multiple PRs.

@RogerHardiman
Copy link
Collaborator

Hi
Thanks for the tests.

There used to be a way to make the tests run against a real camera by setting HOSTNAME, PORT, USERNAME and PASSWORD as environment variables.
However I think it is broken at the moment.

But assuming it gets fixed, we would want to block the Reset (and also the Reboot commands) or our tests against a real camera would make the camera reboot and other tests would time out.

Anyway this is fine for the Mock server.

@RogerHardiman RogerHardiman merged commit 1139f70 into agsh:master Feb 20, 2020
@bl0ggy bl0ggy deleted the add_setSystemFactoryDefault branch March 18, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants