Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cam works properly like EventEmitter inheritor #181

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Make Cam works properly like EventEmitter inheritor #181

merged 1 commit into from
Jan 14, 2021

Conversation

agsh
Copy link
Owner

@agsh agsh commented Dec 25, 2020

Hi! I remembered a conversation that was in May ( sometimes I do it ;) ): #137 #161

And finally remove eventEmitter property and made right inheritance from EventEmitter

Since I have not had a camera for testing for two years, please check the code and maybe test it on the device.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 88.401% when pulling 0904014 on revert-event-emitter into fe5d7f3 on master.

@agsh agsh merged commit 38a75a9 into master Jan 14, 2021
@agsh agsh deleted the revert-event-emitter branch November 26, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswiggins chriswiggins Awaiting requested review from chriswiggins

@RogerHardiman RogerHardiman Awaiting requested review from RogerHardiman

Assignees

@chriswiggins chriswiggins

@RogerHardiman RogerHardiman

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agsh @coveralls @chriswiggins @RogerHardiman