Fix "author" shadowing

If you use the variable "author" in the front matter, it is interpreted as the writer of the article. So changing book review "authors" to "book_author" for clarity.
agude · Apr 6, 2024 · 9dd9147 · 9dd9147
1 parent 7ef08b5
commit 9dd9147
Show file tree

Hide file tree

Showing 40 changed files with 49 additions and 49 deletions.
diff --git a/_books/blindsight.md b/_books/blindsight.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-01
 title: Blindsight
-author: Peter Watts
+book_author: Peter Watts
 series: Firefall
 book_number: 1
 rating: 5

diff --git a/_books/chevalier.md b/_books/chevalier.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-21
 title: Chevalier
-author: Scott Warren
+book_author: Scott Warren
 series: War Horses
 book_number: 1
 rating: 3

diff --git a/_books/consider_phlebas.md b/_books/consider_phlebas.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-09-10
 title: Consider Phlebas
-author: Iain M. Banks
+book_author: Iain M. Banks
 series: Culture
 book_number: 1
 rating: 1

diff --git a/_books/dog_soldier.md b/_books/dog_soldier.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-04-04
 title: Dog Soldier
-author: Scott Warren
+book_author: Scott Warren
 series: War Horses
 book_number: 4
 rating: 4

diff --git a/_books/excession.md b/_books/excession.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-03-25
 title: Excession
-author: Iain M. Banks
+book_author: Iain M. Banks
 series: Culture
 book_number: 5
 rating: 4

diff --git a/_books/hyperion.md b/_books/hyperion.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-10-17
 title: Hyperion
-author: Dan Simmons
+book_author: Dan Simmons
 series: Hyperion Cantos
 book_number: 1
 rating: 4

diff --git a/_books/judas_unchained.md b/_books/judas_unchained.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-09-03
 title: Judas Unchained
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: Commonwealth Saga
 book_number: 2
 rating: 5

diff --git a/_books/night_without_stars.md b/_books/night_without_stars.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-12-15
 title: Night Without Stars
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: The Chronicle of the Fallers
 book_number: 2
 rating: 5

diff --git a/_books/pandoras_star.md b/_books/pandoras_star.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-08-23
 title: Pandora's Star
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: Commonwealth Saga
 book_number: 1
 rating: 5

diff --git a/_books/redwall.md b/_books/redwall.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-02-18
 title: Redwall
-author: Brian Jacques
+book_author: Brian Jacques
 series: Redwall
 book_number: 1
 rating: 4

diff --git a/_books/serpent_valley.md b/_books/serpent_valley.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-30
 title: Serpent Valley
-author: Scott Warren
+book_author: Scott Warren
 series: War Horses
 book_number: 3
 rating: 5

diff --git a/_books/the_abyss_beyond_dreams.md b/_books/the_abyss_beyond_dreams.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-12-08
 title: The Abyss Beyond Dreams
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: The Chronicle of the Fallers
 book_number: 1
 rating: 5

diff --git a/_books/the_causal_angel.md b/_books/the_causal_angel.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-18
 title: The Causal Angel
-author: Hannu Rajaniemi
+book_author: Hannu Rajaniemi
 series: Jean le Flambeur
 book_number: 3
 rating: 3

diff --git a/_books/the_citadel_of_the_autarch.md b/_books/the_citadel_of_the_autarch.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-01-26
 title: The Citadel of the Autarch
-author: Gene Wolfe
+book_author: Gene Wolfe
 series: The Book of the New Sun
 book_number: 4
 rating: 5

diff --git a/_books/the_claw_of_the_conciliator.md b/_books/the_claw_of_the_conciliator.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-01-07
 title: The Claw of the Conciliator
-author: Gene Wolfe
+book_author: Gene Wolfe
 series: The Book of the New Sun
 book_number: 2
 rating: 3

diff --git a/_books/the_dreaming_void.md b/_books/the_dreaming_void.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-09-26
 title: The Dreaming Void
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: The Void Trilogy
 book_number: 1
 rating: 5

diff --git a/_books/the_evolutionary_void.md b/_books/the_evolutionary_void.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-10-12
 title: The Evolutionary Void
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: The Void Trilogy
 book_number: 3
 rating: 4

diff --git a/_books/the_fall_of_hyperion.md b/_books/the_fall_of_hyperion.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-10-27
 title: The Fall of Hyperion
-author: Dan Simmons
+book_author: Dan Simmons
 series: Hyperion Cantos
 book_number: 2
 rating: 5

diff --git a/_books/the_fractal_prince.md b/_books/the_fractal_prince.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-13
 title: The Fractal Prince
-author: Hannu Rajaniemi
+book_author: Hannu Rajaniemi
 series: Jean le Flambeur
 book_number: 2
 rating: 4

diff --git a/_books/the_player_of_games.md b/_books/the_player_of_games.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-02-19
 title: The Player of Games
-author: Iain M. Banks
+book_author: Iain M. Banks
 series: Culture
 book_number: 2
 rating: 5

diff --git a/_books/the_quantum_thief.md b/_books/the_quantum_thief.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-07
 title: The Quantum Thief
-author: Hannu Rajaniemi
+book_author: Hannu Rajaniemi
 series: Jean le Flambeur
 book_number: 1
 rating: 2

diff --git a/_books/the_shadow_of_the_torturer.md b/_books/the_shadow_of_the_torturer.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-12-25
 title: The Shadow of the Torturer
-author: Gene Wolfe
+book_author: Gene Wolfe
 series: The Book of the New Sun
 book_number: 1
 rating: 4

diff --git a/_books/the_state_of_the_art.md b/_books/the_state_of_the_art.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-03-08
 title: The State of the Art
-author: Iain M. Banks
+book_author: Iain M. Banks
 series: Culture
 book_number: 4
 rating: 3

diff --git a/_books/the_sword_of_the_lictor.md b/_books/the_sword_of_the_lictor.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-01-16
 title: The Sword of the Lictor
-author: Gene Wolfe
+book_author: Gene Wolfe
 series: The Book of the New Sun
 book_number: 3
 rating: 4

diff --git a/_books/the_temporal_void.md b/_books/the_temporal_void.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-10-03
 title: The Temporal Void
-author: Peter F. Hamilton
+book_author: Peter F. Hamilton
 series: The Void Trilogy
 book_number: 2
 rating: 4

diff --git a/_books/the_three_body_problem.md b/_books/the_three_body_problem.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-04-01
 title: The Three-Body Problem
-author: Liu Cixin
+book_author: Liu Cixin
 series: Remembrance of Earth's Past
 book_number: 1
 rating: 1

diff --git a/_books/the_urth_of_the_new_sun.md b/_books/the_urth_of_the_new_sun.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-02-09
 title: The Urth of the New Sun
-author: Gene Wolfe
+book_author: Gene Wolfe
 series: The Book of the New Sun
 book_number: 5
 rating: 3

diff --git a/_books/there_is_no_antimemetics_division.md b/_books/there_is_no_antimemetics_division.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-10-29
 title: There Is No Antimemetics Division
-author: qntm
+book_author: qntm
 series: null
 book_number: 2
 rating: 3

diff --git a/_books/use_of_weapons.md b/_books/use_of_weapons.md
@@ -1,7 +1,7 @@
 ---
 date: 2024-02-28
 title: Use of Weapons
-author: Iain M. Banks
+book_author: Iain M. Banks
 series: Culture
 book_number: 3
 rating: 5

diff --git a/_books/ymir.md b/_books/ymir.md
@@ -1,7 +1,7 @@
 ---
 date: 2023-11-25
 title: Ymir
-author: Scott Warren
+book_author: Scott Warren
 series: War Horses
 book_number: 2
 rating: 4

diff --git a/_includes/auto_book_card.html b/_includes/auto_book_card.html
@@ -15,7 +15,7 @@
 url=book.url
 image=book.image
 title=book.title
-author=book.author
+author=book.book_author
 rating=book.rating
 description=book.excerpt
 %}

diff --git a/_includes/related_books.html b/_includes/related_books.html
@@ -52,7 +52,7 @@ <h2>Recent Books</h2>
               url=book.url
               image=book.image
               title=book.title
-              author=book.author
+              author=book.book_author
               rating=book.rating
               description=book.excerpt
             %}
@@ -69,12 +69,12 @@ <h2>Recent Books</h2>
 {% endif %}
 
 {% comment %} Then books by the same author {% endcomment %}
-{% if page.author != empty %}
+{% if page.book_author != empty %}
   {% for book in reversed_chronological_books %}
     {% if book.url != page.url %}
       {% if placed_books.size < 3 %}
         {% comment %}Pick same author{% endcomment %}
-        {% if book.author == page.author %}
+        {% if book.book_author == page.book_author %}
           {% unless placed_books contains book.url %}
             {% comment %} Place the h2 if we haven't already {% endcomment %}
             {% if placed_h2 == false %}
@@ -88,7 +88,7 @@ <h2>Recent Books</h2>
               url=book.url
               image=book.image
               title=book.title
-              author=book.author
+              author=book.book_author
               rating=book.rating
               description=book.excerpt
             %}
@@ -123,7 +123,7 @@ <h2>Recent Books</h2>
             url=book.url
             image=book.image
             title=book.title
-            author=book.author
+            author=book.book_author
             rating=book.rating
             description=book.excerpt
           %}

diff --git a/_layouts/author_page.html b/_layouts/author_page.html
@@ -19,7 +19,7 @@ <h2> heading.{% endcomment %}
 
 {% for book in site.books %}
   {% comment %}Keep only the correct author.{% endcomment %}
-  {% if book.author == page.author_name %}
+  {% if book.book_author == page.author_name %}
     {% assign sorted_series = sorted_series | append: book.series | append: "|" %}
   {% endif %}
 {% endfor %}
@@ -30,7 +30,7 @@ <h2> heading.{% endcomment %}
 have to test if they exist though first to make our header logic easier.{% endcomment %}
 {% assign placed_no_series_header = false %}
 {% for book in sorted_books_by_title %}
-  {% if book.author == page.author_name %}
+  {% if book.book_author == page.author_name %}
     {% if book.series == '' or book.series == null %}
       {% if placed_no_series_header == false %}
         {% assign placed_no_series_header = true %}
@@ -44,7 +44,7 @@ <h2 class="book-list-headline">Standalone Books</h2>
         url=book.url
         image=book.image
         title=book.title
-        author=book.author
+        author=book.book_author
         rating=book.rating
         description=book.excerpt
       %}
@@ -84,7 +84,7 @@ <h2 class="book-list-headline">{{ sort_series }}</h2>
         url=book.url
         image=book.image
         title=book.title
-        author=book.author
+        author=book.book_author
         rating=book.rating
         description=book.excerpt
       %}

diff --git a/_layouts/book.html b/_layouts/book.html
@@ -13,7 +13,7 @@ <h1 class="page-title">{{ page.title }}</h1>
   </div>
   {% endif %}
 
-  <div class="written-by">By {% include author_link.html name=page.author%}</div>
+  <div class="written-by">By {% include author_link.html name=page.book_author%}</div>
 
   {% if page.series %}
   <div class="book-series">Book {{page.book_number}} of the '{{ page.series }}'</div>

diff --git a/_scripts/make_author_pages.py b/_scripts/make_author_pages.py
@@ -22,7 +22,7 @@
 for file in markdown_files:
     with open(file, "r") as opened_file:
         for line in opened_file.readlines():
-            if line.startswith("author: "):
+            if line.startswith("book_author: "):
                 author = line.split(": ")[1].strip()
                 authors.append(author)