refactor: resolve code smell

agustinusnathaniel · Dec 26, 2020 · 7297019 · 7297019
1 parent 26cb825
commit 7297019
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/src/components/form/SearchContainer.tsx b/src/components/form/SearchContainer.tsx
@@ -48,7 +48,7 @@ const INITIAL_VALUES: SearchFormValueType = {
 const SearchContainer = () => {
   const {
     values: {
-      queryParams: { title, description, https, cors, category },
+      queryParams: { title, description, https, category },
       searchDescription,
       selectCategory,
       isRandom,
@@ -177,9 +177,9 @@ const SearchContainer = () => {
                         value={category}
                         onChange={handleChange}
                       >
-                        {categories?.map((category: string, index) => (
+                        {categories?.map((categoryItem: string, index) => (
                           <Text as="option" key={index}>
-                            {category}
+                            {categoryItem}
                           </Text>
                         ))}
                       </Select>

diff --git a/src/pages/all.tsx b/src/pages/all.tsx
@@ -60,27 +60,27 @@ const All = () => {
   const filterData = () => {
     const kword = keyword.toLowerCase();
     const updateFilteredData = sortedData.filter(
-      (data) =>
-        data.API.toLowerCase().indexOf(kword) > -1 ||
-        data.Description.toLowerCase().indexOf(kword) > -1
+      (entry) =>
+        entry.API.toLowerCase().indexOf(kword) > -1 ||
+        entry.Description.toLowerCase().indexOf(kword) > -1
     );
 
     setFiltedData(updateFilteredData);
   };
 
   useEffect(() => {
     if (data?.entries) {
-      const updateSortedData =
-        data &&
-        data.entries.sort((a, b) => {
-          if (a.API < b.API) {
-            return -1;
-          }
-          if (a.API > b.API) {
-            return 1;
-          }
-          return 0;
-        });
+      const updateSortedData = data && data.entries;
+
+      updateSortedData.sort((a, b) => {
+        if (a.API < b.API) {
+          return -1;
+        }
+        if (a.API > b.API) {
+          return 1;
+        }
+        return 0;
+      });
       setSortedData(updateSortedData);
     }
   }, [data]);