Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'README.md' to include correct examples on how to use the 'ctx' p… #255

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

raverona
Copy link
Contributor

…arameter

The 'ctx' parameter accepts one of two values: 'thread' to run the scheduled job on a separate thread, which is the default behaviour if no 'ctx' value is specified, or 'multiprocess' to run the scheduled job on a separate process. The 'README.md' file incorrectly showed 'process' as a valid value for the 'ctx' parameter and none of the correct values mentioned before.

Fixes: #254

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files           7        7           
  Lines         312      312           
  Branches       41       41           
=======================================
  Hits          227      227           
  Misses         76       76           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faeba76...af490e5. Read the comment docs.

The 'ctx' parameter accepts one of two values: 'thread' to run the scheduled job on a separate thread, which is the default behaviour if no 'ctx' value is specified, or 'multiprocess' to run the scheduled job on a separate process. The 'README.md' file incorrectly showed 'process' as a valid value for the 'ctx' parameter and none of the correct values mentioned before.

Fixes: #254
@ghost ghost assigned ahawker Oct 11, 2018
@ghost ghost added the in progress label Oct 11, 2018
@ahawker ahawker merged commit 2232492 into ahawker:master Oct 11, 2018
@ahawker
Copy link
Owner

ahawker commented Oct 11, 2018

@raverona Thanks for the contribution!

@ghost ghost removed the in progress label Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants