Update rules_nodejs 1.1.0 --> 1.6.0

aherrmann · Apr 16, 2020 · 96c3ce9 · 96c3ce9
1 parent 7761eff
commit 96c3ce9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -14,6 +14,10 @@ load("//:defs_1_1.bzl", "my_ts_library")
 #     [link_node_modules.js] mkdir( @my )
 #     [link_node_modules.js] symlink( @my/lib -> /.../execroot/repro/bazel-out/k8-fastbuild/bin/mylib )
 
+# With defs_1_1 & rules_nodejs 1.6.0
+#
+#     uselib.ts(1,21): error TS2307: Cannot find module '@my/lib'.
+
 my_ts_library(
     name = "uselib",
     tsconfig = "tsconfig.json",

diff --git a/WORKSPACE b/WORKSPACE
@@ -2,18 +2,18 @@ workspace(name = "repro", managed_directories = {"@npm": ["node_modules"]})
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-http_archive(
-    name = "build_bazel_rules_nodejs",
-    sha256 = "c97bf38546c220fa250ff2cc052c1a9eac977c662c1fc23eda797b0ce8e70a43",
-    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/1.1.0/rules_nodejs-1.1.0.tar.gz"],
-)
-
 #http_archive(
 #    name = "build_bazel_rules_nodejs",
-#    sha256 = "f9e7b9f42ae202cc2d2ce6d698ccb49a9f7f7ea572a78fd451696d03ef2ee116",
-#    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/1.6.0/rules_nodejs-1.6.0.tar.gz"],
+#    sha256 = "c97bf38546c220fa250ff2cc052c1a9eac977c662c1fc23eda797b0ce8e70a43",
+#    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/1.1.0/rules_nodejs-1.1.0.tar.gz"],
 #)
 
+http_archive(
+    name = "build_bazel_rules_nodejs",
+    sha256 = "f9e7b9f42ae202cc2d2ce6d698ccb49a9f7f7ea572a78fd451696d03ef2ee116",
+    urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/1.6.0/rules_nodejs-1.6.0.tar.gz"],
+)
+
 load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install")
 
 yarn_install(