Sign images with Cosign #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahgencer
added
enhancement
|
Whoops, accidentally closed this. This is still an ongoing issue. |
|
Reopened in PR #3. |
Repository owner
locked and limited conversation to collaborators
Feb 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the efforts to sign the published images using Cosign and rebase to the signed image with
ostree-image-signed.Here's the current progress so far:
publish.ymlaction to install and sign the images with Cosign. The image signatures are stored alongside the images on the container registry, and can be verified locally withcosign verify. The private key is stored in a GitHub Secret, which means a new private key needs to be configured for forks of this repository.containers-policy.json(5)andcontainers-registries.d(5)to specify the path to the public keyocitree.pub. When pulling the images withpodman pull, the signatures are verified as expected.Now, the remaining problem is to get
rpm-ostreeto verify the signature during a rebase / upgrade. For some reason, it doesn't reject images with incorrect or no signatures, even though it rebases toostree-image-signed:<IMAGE>just fine. For now, I filed coreos/rpm-ostree#4272 to see if this is a bug.