Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to give enable or disable the AMP from the categories or product pages or any custom taxonomy in AMP #4326

Open
akashagrjsr opened this issue Mar 30, 2020 · 7 comments
Open

Need to give enable or disable the AMP from the categories or product pages or any custom taxonomy in AMP #4326

akashagrjsr opened this issue Mar 30, 2020 · 7 comments
Assignees
@WasimM3
Labels
enhancement [Priority: HIGH]
Milestone
Stabilize 6.0

Comments

@akashagrjsr
Copy link

No description provided.

@akashagrjsr
Copy link
Author

REF : https://secure.helpscout.net/conversation/1123174927/119589?folderId=2770545

WasimM3 added a commit that referenced this issue Apr 1, 2020
@WasimM3
#4326 - Option to hide/show category and it's related post
4cec43a
WasimM3 added a commit that referenced this issue Apr 2, 2020
@WasimM3
#4326 - Tag and Custom Taxonomy support
dc924c0
@MohammedKaludi
Copy link
Collaborator

Need improvements in the UI.

Please call me when you are working on it. https://monosnap.com/file/9CGhThVMsSiMah2nUiktQ0WoGSK0Jq

@MohammedKaludi MohammedKaludi mentioned this issue Apr 14, 2020
Closed
@MohammedKaludi MohammedKaludi changed the title Need to give show or hide option for the product pages in AMP Need to give enable or disable the AMP from the categories or product pages or any custom taxonomy in AMP Apr 14, 2020
WasimM3 added a commit that referenced this issue Apr 28, 2020
@WasimM3
#4326 - UX improvement
96df77f
WasimM3 added a commit that referenced this issue Apr 29, 2020
@WasimM3
#4326 - Added Tutorial Link
31c0451
@MohammedKaludi
Copy link
Collaborator

UI is very good now, need to make sure that Hide AMP bulk tools is working in conjunction with this control.

Do call me before starting working on it

WasimM3 added a commit that referenced this issue May 1, 2020
@WasimM3
#4326 - Some more improvement
3c2a9b7
@sonaliramteke
Copy link
Contributor

Radio button is not working properly - https://prnt.sc/s9joau

WasimM3 added a commit that referenced this issue May 6, 2020
@WasimM3
#4326 - Fixed the issue of redio button selection no working
0f94baa
@ajeetku
Copy link
Contributor

ajeetku commented May 7, 2020 •
edited
Loading

Suggestion: better way to remove argument from url on 3c2a9b7#diff-ab576767b896423d184ddafe2ede2310R86 & 3c2a9b7#diff-ab576767b896423d184ddafe2ede2310R87
we can use remove_query_arg

WasimM3 added a commit that referenced this issue May 13, 2020
@WasimM3
#4326 - Improved removal of qurey var arg
8663566
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

WasimM3 added a commit that referenced this issue May 15, 2020
@WasimM3
#4326 - Merged in 1.0.50
11f6619
WasimM3 added a commit that referenced this issue May 20, 2020
@WasimM3
#4326 - Added Escaping
0f2a38f
WasimM3 added a commit that referenced this issue May 20, 2020
@WasimM3
#4326 - Changed the filter name
5ea1855
@HaripriyaHari
Copy link

Another user has the same issue: https://wordpress.org/support/topic/amp-for-only-one-category-posts-or-tag-posts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WasimM3 WasimM3

Labels
enhancement [Priority: HIGH]
Projects
None yet
Milestone
Stabilize 6.0
Development

No branches or pull requests
6 participants
@MohammedKaludi @ajeetku @HaripriyaHari @akashagrjsr @sonaliramteke @WasimM3