Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPRocket CDN is not working properly with the amp pages. #4342

Closed
Laxmikanth2502 opened this issue Apr 2, 2020 · 33 comments
Closed

WPRocket CDN is not working properly with the amp pages. #4342

Laxmikanth2502 opened this issue Apr 2, 2020 · 33 comments

Comments

@Laxmikanth2502
Copy link

REF:https://secure.helpscout.net/conversation/1120211367/118861?folderId=3528427

Ref:(https://prnt.sc/rrg8wh).(https://prnt.sc/rrgajg)

WPRocket CDN is not working properly with the amp pages.

@MohammedKaludi MohammedKaludi added this to the Stabilize 4.0 milestone Apr 2, 2020
@Zabi09 Zabi09 self-assigned this Apr 4, 2020
Zabi09 added a commit that referenced this issue Apr 6, 2020
@amarilindra
Copy link

amarilindra commented Apr 9, 2020

I have raised this issue with ticket number - 1923

I implemented the code changes in 73c5b12 commit but the issue is not solved completely.

  1. It breaks images in related posts. All related posts images are showing the default placeholder image.
  2. Images in posts are not completely using CDN. Only the "src" URL is changed to CDN URL. But it has no HTTP/HTTPS protocols added.

Example:
Actual output: cdn.geekdashboard.com/wp-content/uploads/.........
Expected output: https://cdn.geekdashboard.com/wp-content/uploads/.........

  1. Image URLs inside "srcset" are still using non-CDN images.

  2. SD-default-image is still using non-CDN image.

  3. All other images like logos etc are still using non-CDN images.

Please find the below image for more information.

Screenshot 2020-04-09 at 7 44 05 PM

@MainakMK
Copy link

Any new updates on this bug?
Fix this issue ASAP.

Zabi09 added a commit that referenced this issue Apr 27, 2020
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

Zabi09 added a commit that referenced this issue May 15, 2020
@MohammedKaludi
Copy link
Collaborator

Fixed and pushed in 1.0.50

@WasimM3 WasimM3 reopened this May 26, 2020
@WasimM3 WasimM3 self-assigned this May 26, 2020
WasimM3 added a commit that referenced this issue May 26, 2020
@MohammedKaludi
Copy link
Collaborator

Ready to merge

@MainakMK
Copy link

Are you sure, in the next update the problem will fix?

@MohammedKaludi
Copy link
Collaborator

Are you sure, in the next update the problem will fix?

yes, and we are pushing the update in a few hours.

Zabi09 added a commit that referenced this issue May 27, 2020
@MohammedKaludi
Copy link
Collaborator

Pushed in 1.0.51 update

@MainakMK
Copy link

Pushed in 1.0.51 update
The problem is still showing, in amp noting is loaded from CDN even WP Rocket CDN is enabled.

Kindly check from your end before push any update.

@MohammedKaludi
Copy link
Collaborator

Pushed in 1.0.51 update
The problem is still showing, in amp noting is loaded from CDN even WP Rocket CDN is enabled.

Kindly check from your end before push any update.

We have tested it before pushing the update, but is the issue still persists on your end after the update?

@MainakMK
Copy link

Pushed in 1.0.51 update
The problem is still showing, in amp noting is loaded from CDN even WP Rocket CDN is enabled.

Kindly check from your end before push any update.

We have tested it before pushing the update, but is the issue still persists on your end after the update?

Yes, the issue still persists after the update. Kindly check once again.

@MohammedKaludi
Copy link
Collaborator

This is strange, can you please share the screenshot of CDN settings from WP Rocket?

or share the export of your settings at team@ampforwp.com

So we can import/configure the same in our servers and recreate the issue and fix it and push the update immediately.

Zabi09 added a commit that referenced this issue Jun 8, 2020
@MainakMK
Copy link

How many days it will take to Merge?

@MohammedKaludi
Copy link
Collaborator

How many days it will take to Merge?

@MainakMK we have merged the code into the new branch and uploaded into WP.org.

Can you test it with the 1.0.53 using WP Rollback plugin and Install 1.0.53 and let us know your feedback if the fix is properly working or not?

  1. https://monosnap.com/file/uD7xM4QtgTARx5ektqQHk7fsbCuagI
  2. https://monosnap.com/file/CGYyZrwksECCY28kZHGu3OfdhcA5Bg

Can you do that? It will be a great help if you can test it.

@MainakMK
Copy link

Hi,
Working in some cases & other cases not.

First of all Thumbnail image not loading from CDN, still from the main domain.
Also in the post, some images are loading from CDN some of those are not from CDN.

Another thing if some enter https://cdn.example.com in wp rocket CDN Tab., so they facing the error while loading images from https://https://cdn.example.com, conflicting it. But still, perfect when entering cdn.example.com in CDN tab.

Still having issues.

Also not I again roll back to 1.0.52 (Previous version). Waiting for the stable update.

@MohammedKaludi
Copy link
Collaborator

Ready to merge

WasimM3 added a commit that referenced this issue Jun 16, 2020
@MohammedKaludi
Copy link
Collaborator

Updated the code and tested on multiple scenarios and tested with the above-mentioned use-cases and seems to be working.

@MainakMK
Copy link

Sill did not get any update on AMP For WP plugin. Is the bug fixed on Version 1.0.52?

@MohammedKaludi
Copy link
Collaborator

Sill did not get any update on AMP For WP plugin. Is the bug fixed on Version 1.0.52?

Hey @MainakMK

Yesterday night we were able to make the update ready and uploaded in wp.org, can you please use rollback and rollback to 1.0.53 and I think it should now fix the issue.

Can you please check it once again? To make sure the update is stable.

Thank you once again for your cooperation.

@MainakMK
Copy link

Hey @MohammedKaludi

Having the same issue.

  1. First of all thumbnail not loading from CDN.
  2. Which images are cropped by WP system like 696x378, 696x485, 768x486 these images those are not lading from CDN, sill loading from the main domain.

These are the biggest issue still now.

@MohammedKaludi
Copy link
Collaborator

This is strange, we have tested and in our test, it was loading fine.

Can you please shed some light on what do you mean by all images not loading from CDN? Exactly which images? Logo, homepage thumbnails, single images or related post images?

also Which images are cropped by WP system like 696x378, 696x485, 768x486 these images those are not lading from CDN, sill loading from the main domain.

if you could share the URL of that page? that would be very helpful and we can fix it in minutes if we have the live example of the issue?

@MainakMK
Copy link

Hey @MohammedKaludi

Reply on support email, check that with live issue after solve it.

@MohammedKaludi
Copy link
Collaborator

The issue has been fixed and seems to be working.
need some minor more improvement in the code.
once that is done we can close this ticket.

@MainakMK
Copy link

Hey, @MohammedKaludi , Sill did not load images from CDN. Kindly check that website which is shared over email and the plugin is updated to latest version.

@MohammedKaludi
Copy link
Collaborator

Hey, @MohammedKaludi , Sill did not load images from CDN. Kindly check that website which is shared over email and the plugin is updated to latest version.

I still see that you are using 1.0.53.1 version, can you please update to the latest version.

Issue fixed: all the images are now loading from the CDN servers setup in the WPRocket settings.

Issue Pending: Only sub-images from srcset tags for fallback images are loading from the home server and that is a minor improvement required and will be fixed in the future updates.

@MainakMK
Copy link

Hey, @MohammedKaludi , Sill did not load images from CDN. Kindly check that website which is shared over email and the plugin is updated to latest version.

I still see that you are using 1.0.53.1 version, can you please update to the latest version.

Issue fixed: all the images are now loading from the CDN servers setup in the WPRocket settings.

Issue Pending: Only sub-images from srcset tags for fallback images are loading from the home server and that is a minor improvement required and will be fixed in the future updates.

After the latest update, all images are loading from CDN. Thanks

Let's see how long it last, previous this issue fix then within 2 weeks the same issue comes. I hope that it will last forever. 😀

@MohammedKaludi
Copy link
Collaborator

Ready to merge.

WasimM3 added a commit that referenced this issue Jul 6, 2020
@MohammedKaludi
Copy link
Collaborator

Pushed in 1.0.58 update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants