-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPRocket CDN is not working properly with the amp pages. #4342
Comments
I have raised this issue with ticket number - 1923 I implemented the code changes in 73c5b12 commit but the issue is not solved completely.
Example:
Please find the below image for more information. |
Any new updates on this bug? |
Ready to merge. |
Fixed and pushed in 1.0.50 |
Ready to merge |
Are you sure, in the next update the problem will fix? |
yes, and we are pushing the update in a few hours. |
Pushed in 1.0.51 update |
Kindly check from your end before push any update. |
We have tested it before pushing the update, but is the issue still persists on your end after the update? |
Yes, the issue still persists after the update. Kindly check once again. |
This is strange, can you please share the screenshot of CDN settings from WP Rocket? or share the export of your settings at team@ampforwp.com So we can import/configure the same in our servers and recreate the issue and fix it and push the update immediately. |
How many days it will take to Merge? |
@MainakMK we have merged the code into the new branch and uploaded into WP.org. Can you test it with the 1.0.53 using WP Rollback plugin and Install 1.0.53 and let us know your feedback if the fix is properly working or not?
Can you do that? It will be a great help if you can test it. |
Hi, First of all Thumbnail image not loading from CDN, still from the main domain. Another thing if some enter https://cdn.example.com in wp rocket CDN Tab., so they facing the error while loading images from https://https://cdn.example.com, conflicting it. But still, perfect when entering cdn.example.com in CDN tab. Still having issues. Also not I again roll back to 1.0.52 (Previous version). Waiting for the stable update. |
Ready to merge |
Updated the code and tested on multiple scenarios and tested with the above-mentioned use-cases and seems to be working. |
Sill did not get any update on AMP For WP plugin. Is the bug fixed on Version 1.0.52? |
Hey @MainakMK Yesterday night we were able to make the update ready and uploaded in wp.org, can you please use rollback and rollback to 1.0.53 and I think it should now fix the issue. Can you please check it once again? To make sure the update is stable. Thank you once again for your cooperation. |
Hey @MohammedKaludi Having the same issue.
These are the biggest issue still now. |
This is strange, we have tested and in our test, it was loading fine. Can you please shed some light on what do you mean by all images not loading from CDN? Exactly which images? Logo, homepage thumbnails, single images or related post images? also Which images are cropped by WP system like 696x378, 696x485, 768x486 these images those are not lading from CDN, sill loading from the main domain. if you could share the URL of that page? that would be very helpful and we can fix it in minutes if we have the live example of the issue? |
Hey @MohammedKaludi Reply on support email, check that with live issue after solve it. |
The issue has been fixed and seems to be working. |
Hey, @MohammedKaludi , Sill did not load images from CDN. Kindly check that website which is shared over email and the plugin is updated to latest version. |
I still see that you are using 1.0.53.1 version, can you please update to the latest version. Issue fixed: all the images are now loading from the CDN servers setup in the WPRocket settings. Issue Pending: Only sub-images from |
After the latest update, all images are loading from CDN. Thanks Let's see how long it last, previous this issue fix then within 2 weeks the same issue comes. I hope that it will last forever. 😀 |
Ready to merge. |
Pushed in 1.0.58 update |
REF:https://secure.helpscout.net/conversation/1120211367/118861?folderId=3528427
Ref:(https://prnt.sc/rrg8wh).(https://prnt.sc/rrgajg)
WPRocket CDN is not working properly with the amp pages.
The text was updated successfully, but these errors were encountered: