Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even after disabling the lightbox images option still it is working on the images #4442

Closed
kunalaharika opened this issue May 6, 2020 · 5 comments
Closed

Even after disabling the lightbox images option still it is working on the images #4442

kunalaharika opened this issue May 6, 2020 · 5 comments
Assignees
@Zabi09
Labels
bug NEXT UPDATE [Priority: HIGH]
Milestone
Stabilize 5.0

Comments

@kunalaharika
Copy link

kunalaharika commented May 6, 2020 •
edited
Loading

Even after disabling the lightbox images option still, it is working on the images

Ref:https://github.com/ampproject/amphtml/blob/master/spec/auto-lightbox.md

Ref:https://secure.helpscout.net/conversation/1149945786/125773?folderId=3575684
@kunalaharika kunalaharika changed the title Even after disable the lightbox images option still its working on the images Even after disabling the lightbox images option still it is working on the images May 6, 2020
@Zabi09 Zabi09 self-assigned this May 6, 2020
@Zabi09 Zabi09 added this to the Stabilize 5.0 milestone May 6, 2020
Zabi09 added a commit that referenced this issue May 7, 2020
@Zabi09
#4442 lightbox issue fixed
73e0682
@MohammedKaludi
Copy link
Collaborator

MohammedKaludi commented May 7, 2020 •
edited
Loading

@Zabi09 You already know why this ticket failed.

73e0682#diff-b6438fc932bdcf0c8a01c3c146505c9eR398

Zabi09 added a commit that referenced this issue May 8, 2020
@Zabi09
#4442 escaping added
f9ea6d5
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

Zabi09 added a commit that referenced this issue May 8, 2020
@Zabi09
#4442 Added in 1.0.47
c8e08bf
@MohammedKaludi
Copy link
Collaborator

Pushed in 1.0.48 update

@Zabi09 Zabi09 reopened this May 12, 2020
Zabi09 added a commit that referenced this issue May 12, 2020
@Zabi09
#4442 Added in D123
0db3199
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

Zabi09 added a commit that referenced this issue May 15, 2020
@Zabi09
#4442 Added in 1.0.50
ba601d8
@MohammedKaludi
Copy link
Collaborator

Fixed and pushed in 1.0.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zabi09 Zabi09

Labels
bug NEXT UPDATE [Priority: HIGH]
Projects
None yet
Milestone
Stabilize 5.0
Development

No branches or pull requests
3 participants
@MohammedKaludi @Zabi09 @kunalaharika