Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse issues. #4443

Closed
3 of 5 tasks
amer07 opened this issue May 6, 2020 · 4 comments
Closed
3 of 5 tasks

Lighthouse issues. #4443

amer07 opened this issue May 6, 2020 · 4 comments
Assignees
@Zabi09
Labels
bug NEXT UPDATE [Priority: HIGH]
Milestone
Stabilize 5.0

Comments

@amer07
Copy link

amer07 commented May 6, 2020 •
edited by Zabi09
Loading

Case 1: https://secure.helpscout.net/conversation/1156744130/0/?folderId=2770543
Same URL
@Zabi09 Zabi09 added this to the Stabilize 5.0 milestone May 6, 2020
@Zabi09 Zabi09 self-assigned this May 7, 2020
Zabi09 added a commit that referenced this issue May 7, 2020
@Zabi09
#4443 form element fixed
4d8ca04
Zabi09 added a commit that referenced this issue May 7, 2020
@Zabi09
#4443 Links do not have a discernible name fixed
2cf1912
Zabi09 added a commit that referenced this issue May 7, 2020
@Zabi09
#4443 tap targets is not sized properly fixed
db53dc1
@MohammedKaludi
Copy link
Collaborator

MohammedKaludi commented May 11, 2020 •
edited
Loading

Why two taskes are still pending?

@MohammedKaludi
Copy link
Collaborator

id=placement might cause duplication if multiple search forms are added.

4d8ca04#diff-50ca97af891aedfd1983582931b0cda8R29

Zabi09 added a commit that referenced this issue May 15, 2020
@Zabi09
#4443 unique id added
ebcbd9c
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

Zabi09 added a commit that referenced this issue May 15, 2020
@Zabi09
#4443 Added in 1.0.50
cb2187b
@MohammedKaludi
Copy link
Collaborator

Fixed and pushed in 1.0.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zabi09 Zabi09

Labels
bug NEXT UPDATE [Priority: HIGH]
Projects
None yet
Milestone
Stabilize 5.0
Development

No branches or pull requests
3 participants
@MohammedKaludi @Zabi09 @amer07