Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-carousel gallery with captions is not valid amp code #4452

Closed
ghost opened this issue May 11, 2020 · 3 comments
Closed

amp-carousel gallery with captions is not valid amp code #4452

ghost opened this issue May 11, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented May 11, 2020

with

end causing page to turn BLANK

https://wordpress.org/support/topic/amp-carousel-gallery-with-captions-is-not-valid-amp-code/

REf: https://secure.helpscout.net/conversation/1157625419/128114?folderId=3257665

@DrLightman
Copy link

Hello,

amp-carousel was not related to the error.

Instead, the preg_replace() inside the shortpixel compatibiliy filter as I specified in the last replies of the topic you linked.

To try to replicate the issue you may want to try to:

  • enable https://wordpress.org/plugins/shortpixel-adaptive-images/ . I have 1.8.0 right now, have to update

  • attach and embed a lot of images in the body of the post, al least 5 or more, go with 10 if you can, all of them must be one after the other without normal text between them and the amp should minify this html into a long line. while uploading, fill in some alt text for each image too and description via the wp media manager

  • theme in use I have AMP Layouts and both Magazine and News on different sites gave me the error so maybe it's not relevant

my php is 7.4

@Zabi09 Zabi09 added this to the Stabilize 5.0 milestone May 12, 2020
@Zabi09 Zabi09 self-assigned this May 12, 2020
Zabi09 added a commit that referenced this issue May 13, 2020
@MohammedKaludi
Copy link
Collaborator

Ready to merge.

Zabi09 added a commit that referenced this issue May 15, 2020
@MohammedKaludi
Copy link
Collaborator

Fixed and pushed in 1.0.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants