Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more cli tests for kubens #117

Merged
merged 4 commits into from
Jan 3, 2019
Merged

add more cli tests for kubens #117

merged 4 commits into from
Jan 3, 2019

Conversation

doodlesbykumbi
Copy link
Contributor

No description provided.

This was referenced Jan 3, 2019
Closed
Closed
@ahmetb
Copy link
Owner

ahmetb commented Jan 3, 2019

I think you pushed to the branch of #116 so I can't merge that now.

@doodlesbykumbi
Copy link
Contributor Author

doodlesbykumbi commented Jan 3, 2019 •
edited
Loading

@ahmetb i closed #116 and deleted the branch then created a brand new branch with all the changes. you should be good to merge from here. 1 PR to rule them all :)

ahmetb
ahmetb requested changes Jan 3, 2019
View reviewed changes
kubens Outdated Show resolved Hide resolved
kubens Outdated Show resolved Hide resolved
kubens Outdated Show resolved Hide resolved
mock-kubectl Outdated Show resolved Hide resolved
mock-kubectl Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
mock-kubectl Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/common.bash Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/kubens.bats Outdated Show resolved Hide resolved
@doodlesbykumbi
Copy link
Contributor Author

@ahmetb addressed your comments and replied where it made sense to do so

ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/kubens.bats Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/mock-kubectl Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
kubens Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/kubens.bats Outdated Show resolved Hide resolved
ahmetb
ahmetb reviewed Jan 3, 2019
View reviewed changes
test/docker/Dockerfile Outdated Show resolved Hide resolved
@ahmetb
Copy link
Owner

ahmetb commented Jan 3, 2019

Thanks these are looking good now! 🙏

@ahmetb ahmetb merged commit 402cc2c into ahmetb:master Jan 3, 2019
@doodlesbykumbi doodlesbykumbi deleted the tests/kubens branch January 3, 2019 18:10
ahmetb added a commit that referenced this pull request Jan 28, 2019
@ahmetb
v0.6.3
10c9bd5 
- FIX: Show current context/ns color in interactive (fzf) mode. (#109)
- TEST: Add integration tests for kubectx (#111, #113) and kubens (#105, #117)

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doodlesbykumbi @ahmetb @googlebot