Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Go version to 1.22 #425

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Jul 10, 2024

In this PR #416 I added slices.Contains, but it's not available for Go 1.20, replaced it with custom func and added todo

Copy link
Owner

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade Go version instead?
I suspect goreleaser file and github action and go.mod has it.

@idsulik idsulik force-pushed the feat-issue-333_2 branch from 11163a3 to ea5d366 Compare July 10, 2024 15:23
@idsulik idsulik changed the title fix(flags): Replace slices.Contains with sliceContains custom func chore: upgrade Go version to 1.22 Jul 10, 2024
@idsulik
Copy link
Contributor Author

idsulik commented Jul 10, 2024

@ahmetb done

@ahmetb
Copy link
Owner

ahmetb commented Jul 10, 2024

The action needs to be updated too, it seems to be failing.

@idsulik
Copy link
Contributor Author

idsulik commented Jul 10, 2024

updated it as well

@ahmetb ahmetb merged commit 561793c into ahmetb:master Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants