fix: don't freeze definitions for compatibility with sass (arktypeio#901

)
ahrjarrett · Jan 12, 2024 · 93d872a · 93d872a
1 parent 32ecb70
commit 93d872a
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 73 deletions.
diff --git a/README.md b/README.md
@@ -52,7 +52,7 @@ Check out [how it works](#how), [try it in-browser](https://arktype.io/docs/#you
 <sub>(or whatever package manager you prefer)</sub>
 <br />
 
-Our types are tested in [strict-mode](https://www.typescriptlang.org/tsconfig#strict) with TypeScript versions `4.8`, `4.9`, and `5.0`.
+Our types are tested in [strict-mode](https://www.typescriptlang.org/tsconfig#strict) with TypeScript version `4.8` or greater.
 
 _Our APIs have mostly stabilized, but details may still change during the alpha/beta stages of our 1.0 release. If you have suggestions that may require a breaking change, now is the time to let us know!_ ⛵
 
@@ -259,15 +259,12 @@ If the project has been useful to you and you are in a financial position to do
 
 Otherwise, consider sending me an email (david@arktype.io) or [message me on Discord](https://arktype.io/discord) to let me know you're a fan of ArkType. Either would make my day!
 
-### Current Sponsors 🥰
+### ArkSponsors ⛵
 
 <table>
 	<tr>
 		<th>fubhy</th>
 		<th>sam-goodwin</th>
-		<th>tmm</th>
-		<th>thomasballinger</th>
-		<th>jacksteamdev</th>
 	</tr>
 	<tr>
 		<td>
@@ -284,68 +281,63 @@ Otherwise, consider sending me an email (david@arktype.io) or [message me on Dis
 					src="https://avatars.githubusercontent.com/u/38672686"
 			/></a>
 		</td>
+	</tr>
+
+## Sponsors 🥰
+
+<table>
+	<tr>
+		<th>tmm</th>
+		<th>jacksteamdev</th>
+        <th>neodon</th>
+        <th>mewhhaha</th>
+    	<th>codeandcats</th>
+	</tr>
+	<tr>
 		<td>
 			<a href="https://github.com/tmm"
 				><img
 					height="64px"
 					src="https://avatars.githubusercontent.com/u/6759464"
 			/></a>
 		</td>
-		<td>
-			<a href="https://github.com/thomasballinger"
-				><img
-					height="64px"
-					src="https://avatars.githubusercontent.com/u/458879"
-			/></a>
-		</td>
 		<td>
 			<a href="https://github.com/jacksteamdev"
 				><img
 					height="64px"
 					src="https://avatars.githubusercontent.com/u/23390212"
 			/></a>
 		</td>
+        <td>
+    		<a href="https://github.com/neodon"
+    			><img height="64px" src="https://avatars.githubusercontent.com/u/82944"
+    		/></a>
+    	</td>
+        <td>
+    		<a href="https://github.com/mewhhaha"
+    			><img
+    				height="64px"
+    				src="https://avatars.githubusercontent.com/u/3399205"
+    		/></a>
+    	</td>
+    	<td>
+    		<a href="https://github.com/codeandcats"
+    			><img
+    				height="64px"
+    				src="https://avatars.githubusercontent.com/u/6035934"
+    		/></a>
+    	</td>
 	</tr>
 	<tr>
-		<th>neodon</th>
-		<th>mewhhaha</th>
-		<th>codeandcats</th>
-		<th>xrexy</th>
-		<th>Timeraa</th>
-	</tr>
-	<tr>
-		<td>
-			<a href="https://github.com/neodon"
-				><img height="64px" src="https://avatars.githubusercontent.com/u/82944"
-			/></a>
-		</td>
-		<td>
-			<a href="https://github.com/mewhhaha"
-				><img
-					height="64px"
-					src="https://avatars.githubusercontent.com/u/3399205"
-			/></a>
-		</td>
-		<td>
-			<a href="https://github.com/codeandcats"
-				><img
-					height="64px"
-					src="https://avatars.githubusercontent.com/u/6035934"
-			/></a>
-		</td>
-		<td>
-			<a href="https://github.com/xrexy"
-				><img
-					height="64px"
-					src="https://avatars.githubusercontent.com/u/71969236"
-			/></a>
-		</td>
-		<td>
-			<a href="https://github.com/Timeraa"
-				><img
-					height="64px"
-					src="https://avatars.githubusercontent.com/u/29104008"
-			/></a>
-		</td>
-	</tr>
+    	<th>Timeraa</th>
+    </tr>
+    <tr>
+    	<td>
+    		<a href="https://github.com/Timeraa"
+    			><img
+    				height="64px"
+    				src="https://avatars.githubusercontent.com/u/29104008"
+    		/></a>
+    	</td>
+    </tr>
 </table>
diff --git a/dev/configs/.changeset/beige-schools-guess.md b/dev/configs/.changeset/beige-schools-guess.md
@@ -0,0 +1,5 @@
+---
+"arktype": patch
+---
+
+fix: don't freeze definitions for compatibility with sass
diff --git a/src/scopes/cache.ts b/src/scopes/cache.ts
@@ -1,5 +1,3 @@
-import { deepFreeze } from "../utils/freeze.js"
-
 export class Cache<item = unknown> {
     protected cache: { [name in string]?: item } = {}
 
@@ -20,10 +18,3 @@ export class Cache<item = unknown> {
         return item
     }
 }
-
-export class FreezingCache<item = unknown> extends Cache<item> {
-    override set(name: string, item: item) {
-        this.cache[name] = deepFreeze(item) as item
-        return item
-    }
-}
diff --git a/src/scopes/scope.ts b/src/scopes/scope.ts
@@ -15,7 +15,6 @@ import type {
 import { compileProblemWriters } from "../traverse/problems.js"
 import { chainableNoOpProxy } from "../utils/chainableNoOpProxy.js"
 import { throwInternalError, throwParseError } from "../utils/errors.js"
-import { deepFreeze } from "../utils/freeze.js"
 import type {
     Dict,
     error,
@@ -28,7 +27,7 @@ import { hasKeys } from "../utils/generics.js"
 import { Path } from "../utils/paths.js"
 import type { stringifyUnion } from "../utils/unionToTuple.js"
 import type { PrecompiledDefaults } from "./ark.js"
-import { Cache, FreezingCache } from "./cache.js"
+import { Cache } from "./cache.js"
 import type { Expressions } from "./expressions.js"
 import type {
     AnonymousTypeName,
@@ -182,7 +181,7 @@ export const isConfigTuple = (def: unknown): def is ConfigTuple =>
 export class Scope<context extends ScopeContext = any> {
     name: string
     config: ScopeConfig
-    parseCache = new FreezingCache<Node>()
+    parseCache = new Cache<Node>()
     #resolutions = new Cache<Type>()
     #exports = new Cache<Type>()
 
@@ -307,8 +306,8 @@ export class Scope<context extends ScopeContext = any> {
             seen.push(node)
             node = this.#resolveRecurse(node, "throw", seen).node
         }
-        t.node = deepFreeze(node)
-        t.flat = deepFreeze(flattenType(t))
+        t.node = node
+        t.flat = flattenType(t)
         return t
     }
 
@@ -360,12 +359,10 @@ export class Scope<context extends ScopeContext = any> {
             const t = initializeType("λtype", def, config, this)
             const ctx = this.#initializeContext(t)
             const root = parseDefinition(def, ctx)
-            t.node = deepFreeze(
-                hasKeys(config)
-                    ? { config, node: this.resolveTypeNode(root) }
-                    : root
-            )
-            t.flat = deepFreeze(flattenType(t))
+            t.node = hasKeys(config)
+                ? { config, node: this.resolveTypeNode(root) }
+                : root
+            t.flat = flattenType(t)
             return t
         },
         { from: this.expressions.node }