Make a local copy within keyvault pipeline to avoid compilers re-orde…

…ring things.
ahsonkhan · Mar 25, 2021 · bd4844d · bd4844d
1 parent f2d720b
commit bd4844d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/...t/azure-security-keyvault-common/inc/azure/keyvault/common/internal/keyvault_pipeline.hpp b/...t/azure-security-keyvault-common/inc/azure/keyvault/common/internal/keyvault_pipeline.hpp
@@ -101,7 +101,10 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Common { n
     {
       auto request = CreateRequest(method, path);
       auto response = SendRequest(context, request);
-      return Azure::Response<T>(factoryFn(*response), std::move(response));
+      // Saving the value in a local is required before passing it in to Response<T> to avoid
+      // compiler optimizations re-ordering the `factoryFn` function call and the RawResponse move.
+      T value = factoryFn(*response);
+      return Azure::Response<T>(value, std::move(response));
     }
 
     /**
@@ -129,7 +132,10 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Common { n
 
       auto request = CreateRequest(method, &streamContent, path);
       auto response = SendRequest(context, request);
-      return Azure::Response<T>(factoryFn(*response), std::move(response));
+      // Saving the value in a local is required before passing it in to Response<T> to avoid
+      // compiler optimizations re-ordering the `factoryFn` function call and the RawResponse move.
+      T value = factoryFn(*response);
+      return Azure::Response<T>(value, std::move(response));
     }
 
     /**