Proposal: Add magic.set_magic_file
#306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a user I don't really care about the `Magic` class. All I want is to query the magic of some files. Before this commit you had to create an instance of Magic. After this commit you can pass all arguments you would pass to its constructor to the instanceless methods.
|
Since this is global state, other libraries that also depend on python-magic would pickup the change and may get unexpected behavior. I'd support an environment variable that sets the default, since that puts it under the users (rather than potentially a libraries) control. |
|
Obviously a library can set the environment variable, but that's going to be clearly wrong while a function makes it inviting. |
That will be the
Good point, I didn't think if that. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a solution to #305.
I'm not happy with the name of the function and would like to discuss this change in general.
Any comments?