Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size reduction by 14 B #19

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Size reduction by 14 B #19

merged 1 commit into from
Oct 30, 2018

Conversation

gwer
Copy link
Contributor

@gwer gwer commented Oct 30, 2018

Remove bitshifting hack.
Remove variables reuse.
Use [].slice for Object.prototype properties collision fix.

@ai
Copy link
Owner

ai commented Oct 30, 2018

Can you run ./test/benchmark on Node 11 before and after this fix?

I tried this way before, but on old Node.js found big reducing in performance.

@gwer
Copy link
Contributor Author

gwer commented Oct 30, 2018

Are you sure ./test/benchmark should exist?

@ai
Copy link
Owner

ai commented Oct 30, 2018

Oops, it is a wrong nano* project :D

I thought I was in Nano ID

@ai ai merged commit cd2f9c1 into ai:master Oct 30, 2018
@ai
Copy link
Owner

ai commented Oct 30, 2018

Thanks. Released in 1.0.8.

@StreetStrider
Copy link

That was a beautiful in-place hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwer @ai @StreetStrider